Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Session] Use server-side authc.getCurrentUser from core.security #186919

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 25, 2024

Part of #186574

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0. The Search Session service uses the authc.getCurrentUser method as a means to create a scoped client with methods that filters saved search sessions to the current user.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan
Copy link
Member Author

/ci

@tsullivan tsullivan marked this pull request as ready for review June 26, 2024 17:04
@tsullivan tsullivan requested review from a team as code owners June 26, 2024 17:04
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
data 54 55 +1

References to deprecated APIs

id before after diff
data 29 28 -1

Total ESLint disabled count

id before after diff
data 56 57 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 3d99878 into elastic:main Jun 27, 2024
24 checks passed
@tsullivan tsullivan deleted the security-in-core/data-search-session-server-plugin-server branch June 27, 2024 21:29
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants