[Actions Plugin] Use server-side authc.getCurrentUser from core.security #186924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
tsullivan
commented
Jun 25, 2024
| @@ -645,7 +645,6 @@ export class ActionsPlugin implements Plugin<PluginSetupContract, PluginStartCon | |||
| request, | |||
| authorizationMode, | |||
| authorization: this.security?.authz, | |||
| authentication: this.security?.authc, | |||
There was a problem hiding this comment.
The authentication property was unused and used the deprecated access method to the APIs
tsullivan
force-pushed
the
security-in-core/actions-server-plugin-server
branch
from
91a9e28 to
5c4d2c8
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
tsullivan
commented
Jun 28, 2024
| authentication.getCurrentUser.mockReturnValueOnce({ | ||
| username: 'some-user', | ||
| } as unknown as AuthenticatedUser); | ||
|
|
There was a problem hiding this comment.
This piece of code appears to have been unused boilerplate.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #186574
Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0. The Actions plugin uses the
authc.getCurrentUsermethod to attribute the current user to persisted actions that are created in the system.Checklist
Delete any items that are not applicable to this PR.