Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Defend Plugin] Migrate authc.getCurrentUser usage to core.security #187023

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 26, 2024

Part of #186574

Summary

This PR migrates the Cloud Defend Plugin's route handler that consumes authc.getCurrentUser to use coreContext.security.

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan force-pushed the security-in-core/cloud-defend-server-plugin-server branch from 8e0dede to fcf2234 Compare June 26, 2024 20:34
@tsullivan tsullivan marked this pull request as ready for review June 27, 2024 01:02
@tsullivan tsullivan requested a review from a team as a code owner June 27, 2024 01:02
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jun 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan enabled auto-merge (squash) July 1, 2024 23:02
@tsullivan tsullivan merged commit 17de403 into elastic:main Jul 2, 2024
19 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
cloudDefend 8 6 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants