[ESO Plugin] Migrate authc.getCurrentUser usage to coreStart.security #187024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
security-in-core/encrypted-saved-objects-server-plugin-server
branch
from
33b74fa to
2eeefa2
Compare
tsullivan
added
Team:Core
tsullivan
force-pushed
the
security-in-core/encrypted-saved-objects-server-plugin-server
branch
from
1ae7970 to
e76a4f5
Compare
tsullivan
commented
Jul 8, 2024
| getStartServices: coreSetupMock.getStartServices, | ||
| }); | ||
| }); | ||
|
|
||
| describe('#setupContract', () => { | ||
| it('includes hiddenTypes when specified', async () => { | ||
| await setupContract({ includedHiddenTypes: ['hiddenType'] }); | ||
| setupContract({ includedHiddenTypes: ['hiddenType'] }); | ||
| await nextTick(); |
There was a problem hiding this comment.
Minor cleanup here: it was confusing to await setupContract since that function doesn't return a promise. But a promise does get initialized in that function, and the test depends on that promise being resolved.
|
Pinging @elastic/kibana-core (Team:Core) |
…ver-plugin-server
💚 Build Succeeded
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
|
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #186574
Summary
This PR migrates the Encrypted Saved Object Plugin's route handler that consumes
authc.getCurrentUserto usecoreStart.security.Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.
Checklist
Delete any items that are not applicable to this PR.