-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Use authc.getCurrentUser from core.security in browser #187042
[Security Solution] Use authc.getCurrentUser from core.security in browser #187042
Conversation
a952436
to
c64368f
Compare
Pinging @elastic/security-solution (Team: SecuritySolution) |
/ci |
c64368f
to
aa82d28
Compare
lookupRealm: { name: '', type: '' }, | ||
authenticationProvider: '', | ||
}); | ||
const response = await security.authc.getCurrentUser(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the else
because it would have been dead code. SecurityServiceStart
comes from CoreStart and is always present.
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on CI green
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
The functional tests failures currently in this PR are pointing to an issue in the code that is hard to debug. In the following code change: - const { security } = useKibana().services;
+ const { securityService: security } = useKibana().services; We expect that the Example:
In a low-level lib:
This is the same complication that I encountered with #187190. Same as that PR, I'm choosing to close this PR for now. |
follows #187004
Summary
This PR migrates the Security Solution Plugin's browser-side code that consume
authc.getCurrentUser
to use coreStart.securityBackground: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.
Checklist
Delete any items that are not applicable to this PR.