Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logstash Plugin] Migrate authc.getCurrentUser usage to coreContext.security #187180

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 28, 2024

Part of #186574

Summary

This PR migrates the Logstash Plugin's route handler for saving a pipeline, which consumes authc.getCurrentUser, to use coreContext.security.

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan
Copy link
Member Author

/ci

@tsullivan
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
logstash 2 1 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsullivan tsullivan marked this pull request as ready for review July 2, 2024 19:02
@tsullivan tsullivan requested a review from a team as a code owner July 2, 2024 19:02
@tsullivan tsullivan enabled auto-merge (squash) July 2, 2024 19:02
@tsullivan tsullivan added Team:Logstash release_note:skip Skip the PR/issue when compiling release notes labels Jul 2, 2024
@tsullivan tsullivan merged commit 482f2a9 into elastic:main Jul 3, 2024
20 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jul 3, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
logstash 2 1 -1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Logstash v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants