-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logstash Plugin] Migrate authc.getCurrentUser usage to coreContext.security #187180
Merged
tsullivan
merged 5 commits into
elastic:main
from
tsullivan:security-in-core/logstash-server-plugin-browser
Jul 3, 2024
Merged
[Logstash Plugin] Migrate authc.getCurrentUser usage to coreContext.security #187180
tsullivan
merged 5 commits into
elastic:main
from
tsullivan:security-in-core/logstash-server-plugin-browser
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]History
To update your PR or re-run it, just comment with: |
mashhurs
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tsullivan
added
Team:Logstash
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jul 2, 2024
kibanamachine
added
v8.15.0
backport:skip
This commit does not require backporting
labels
Jul 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Logstash
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #186574
Summary
This PR migrates the Logstash Plugin's route handler for saving a pipeline, which consumes
authc.getCurrentUser
, to usecoreContext.security
.Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.
Checklist
Delete any items that are not applicable to this PR.