Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom threshold] Fix adding ECS groups multiple times to recovered alert context #188629

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[Custom threshold] Fix adding ECS groups multiple times to recovered alert context #188629

merged 1 commit into from
Jul 19, 2024

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Jul 18, 2024 •
edited
Loading

Summary

Fix adding ECS group fields to the recovered alert document for the custom threshold rule; previously (PR), it was added to the context instead of the root level.

Before After
image image

The ECS group by fields should be in AAD for all alerts:

Active Recovered No data
image image image

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Jul 18, 2024
@maryam-saeidi maryam-saeidi self-assigned this Jul 18, 2024
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner July 18, 2024 10:20
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jul 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi changed the title Fix adding ECS groups multiple times to recovered alert Fix adding ECS groups multiple times to recovered alert context Jul 18, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 18, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @maryam-saeidi

dominiqueclarke
dominiqueclarke approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with the metric threshold rule during recovery.

@maryam-saeidi
Copy link
Member Author

@dominiqueclarke I just noticed I didn't mention which rule this change is related to, sooorry 🙈 Can you please check it with the custom threshold rule?

@maryam-saeidi maryam-saeidi changed the title Fix adding ECS groups multiple times to recovered alert context [Custom threshold] Fix adding ECS groups multiple times to recovered alert context Jul 19, 2024
dominiqueclarke
dominiqueclarke approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again with custom threshold. LGTM

@maryam-saeidi maryam-saeidi merged commit 80ea217 into elastic:main Jul 19, 2024
32 checks passed
@maryam-saeidi maryam-saeidi deleted the 183220-fix-ct-group-by branch July 19, 2024 16:56
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maryam-saeidi @elasticmachine @obltmachine @dominiqueclarke @kibanamachine