Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS] Include connector APIs #191679

Merged
merged 6 commits into from
Aug 29, 2024
Merged

[OAS] Include connector APIs #191679

merged 6 commits into from
Aug 29, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 28, 2024 •
edited by kibanamachine
Loading

Summary

Similar to #189962, this PR aims to start using the generated output for the connector API documentation.

To refresh the output files, run node scripts/capture_oas_snapshot --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --update

@lcawl lcawl added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS labels Aug 28, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review August 29, 2024 00:54
@lcawl lcawl requested a review from a team as a code owner August 29, 2024 00:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from a team August 29, 2024 00:54
jbudz
jbudz approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildkite

lcawl and others added 3 commits August 29, 2024 10:37
@lcawl
Merge branch 'main' into connector-apis
0c578fb
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
fbb3d3f 
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --update'
@lcawl
Merge branch 'main' into connector-apis
6b99072
@lcawl lcawl enabled auto-merge (squash) August 29, 2024 19:24
@lcawl
Copy link
Contributor Author

lcawl commented Aug 29, 2024

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 4a3fa7e into elastic:main Aug 29, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191679

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the connector-apis branch August 29, 2024 23:35
lcawl added a commit to lcawl/kibana that referenced this pull request Aug 29, 2024
@lcawl
[OAS] Include connector APIs (elastic#191679)
bfa98f1 
(cherry picked from commit 4a3fa7e)
@lcawl lcawl mentioned this pull request Aug 29, 2024
Closed
@lcawl
Copy link
Contributor Author

lcawl commented Aug 29, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl mentioned this pull request Aug 30, 2024
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 31, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@lcawl lcawl added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @obltmachine @elasticmachine @kibana-ci @kibanamachine @jbudz