[Cloud Security] Adding unprivileged state to benchmark page #195172
Conversation
JordanSh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
|
We should disable the pop up since it's displaying the same message, no reason to present it twice.
|
It has the "show full error" functionality which also include the user and role. |
There was a problem hiding this comment.
LGTM, A minor suggestion: I found showNoFindingsStates a bit confusing, as there may be findings, but the user lacks the necessary privileges. However, I noticed we use the same term in other parts of the code, and changing it would require a larger refactor beyond this specific section.
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JordanSh |
|
Starting backport for target branches: 8.x |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…195172) (#195298) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Adding unprivileged state to benchmark page (#195172)](#195172) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T16:49:09Z","message":"[Cloud Security] Adding unprivileged state to benchmark page (#195172)","sha":"5d7de2f6c259f9db674d23d67e946d24b23efdc2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor"],"title":"[Cloud Security] Adding unprivileged state to benchmark page","number":195172,"url":"https://github.com/elastic/kibana/pull/195172","mergeCommit":{"message":"[Cloud Security] Adding unprivileged state to benchmark page (#195172)","sha":"5d7de2f6c259f9db674d23d67e946d24b23efdc2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195172","number":195172,"mergeCommit":{"message":"[Cloud Security] Adding unprivileged state to benchmark page (#195172)","sha":"5d7de2f6c259f9db674d23d67e946d24b23efdc2"}}]}] BACKPORT--> Co-authored-by: Jordan <[email protected]>
Summary
Resolves #194056
Added unprivileged state to the benchmark page. in video i start by using a user without required index privileges and switch to a super user
Screen.Recording.2024-10-06.at.18.09.00.mov