-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-actions: notify github commands for all the observability code #195219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
release_note:skip
Skip the PR/issue when compiling release notes
skip-ci
backport:prev-major
Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development
labels
Oct 7, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
reakaleek
approved these changes
Oct 7, 2024
jbudz
reviewed
Oct 7, 2024
v1v
commented
Oct 7, 2024
jbudz
approved these changes
Oct 7, 2024
Starting backport for target branches: 8.15, 8.x |
💚 Build Succeeded
Metrics [docs]
cc @v1v |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
…elastic#195219) (cherry picked from commit 94aa915)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…y code (#195219) (#195319) # Backport This will backport the following commits from `main` to `8.x`: - [github-actions: notify github commands for all the observability code (#195219)](#195219) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Victor Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T20:19:08Z","message":"github-actions: notify github commands for all the observability code (#195219)","sha":"94aa9151695ec4d7a001195aa10cc25ea6e2d282","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"github-actions: notify github commands for all the observability code","number":195219,"url":"https://github.com/elastic/kibana/pull/195219","mergeCommit":{"message":"github-actions: notify github commands for all the observability code (#195219)","sha":"94aa9151695ec4d7a001195aa10cc25ea6e2d282"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195219","number":195219,"mergeCommit":{"message":"github-actions: notify github commands for all the observability code (#195219)","sha":"94aa9151695ec4d7a001195aa10cc25ea6e2d282"}}]}] BACKPORT--> Co-authored-by: Victor Martinez <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-major
Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development
release_note:skip
Skip the PR/issue when compiling release notes
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the ephemeral
GITHUB_TOKEN
to write a comment if the label isci:project-deploy-observability
.As far as I see there is no need to use a PAT to distinguish if the person who raised the PR was someone from the community.
There are
700
PRs from the community versus125k
Therefore, I think this new implementation is safer than the other one, even if there is a comment about using some GH commands that won't be available for the community members but only Elastic employees.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers