[8.x] [ResponseOps][Alerting] Error when submit rule form when using AddFilterPopover in actions (#194600) #195228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terPopover in actions (elastic#194600) Resolve: elastic#192847 When user try to save the rule which has a conditional action with a filter which contains AND or OR, it'll fail. Error raises when a new rule SO object is going to be created. Validation fails because schema is wrong. I fixed it in this PR. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### How to test 1. Go to Rules and try creating a new rule of any type 2. Add an action to the rule 3. Check the option If alert matches a query 4. Click the + icon to add a filter 5. Create a filter in the popover 6. Click AND or OR 7. Create another filter 8. Click Add filter 9. Try saving the rule 10. Saving should be successful (cherry picked from commit 02d0c98)
Merged
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @guskovaue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation