Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 2 (#193638) #195230

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

animehart
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

elastic#193638)

In an attempt to make Reviewing easier and more accurate, the
implementation of Vulnerabilities on Host.name flyout in Alerts Page
will be split into 2 Phases

Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package
Phase 2: Implementing the feature

This is Phase 2
<img width="1465" alt="Screenshot 2024-09-20 at 5 33 01 PM"
src="https://github.com/user-attachments/assets/cabe2f3a-d35a-4825-9fe5-61fe2d570328">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Maxim Kholod <[email protected]>
(cherry picked from commit 0b92c26)

# Conflicts:
#	.github/CODEOWNERS
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 652 654 +2
securitySolution 5921 5925 +4
total +6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cloud-security-posture 74 78 +4
@kbn/cloud-security-posture-common 86 92 +6
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 507.6KB 507.6KB -6.0B
securitySolution 20.6MB 20.6MB +28.9KB
total +28.9KB
Unknown metric groups

API count

id before after diff
@kbn/cloud-security-posture 74 78 +4
@kbn/cloud-security-posture-common 88 94 +6
total +10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@@ -0,0 +1,1859 @@
####
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the CODEOWNERS as it has been intentionally removed from the 8.x branch

@animehart animehart merged commit f9c640d into elastic:8.x Oct 8, 2024
32 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 652 654 +2
securitySolution 5921 5925 +4
total +6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cloud-security-posture 74 78 +4
@kbn/cloud-security-posture-common 86 92 +6
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 507.6KB 507.6KB -6.0B
securitySolution 20.6MB 20.6MB +28.9KB
total +28.9KB
Unknown metric groups

API count

id before after diff
@kbn/cloud-security-posture 74 78 +4
@kbn/cloud-security-posture-common 88 94 +6
total +10

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants