[Security Solution][Notes] - allow filtering by note association #195501
+409
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
backport
release_note:skip
PhilippeOberti
force-pushed
the
notes-management-filters
branch
2 times, most recently
from
4bce942 to
9dac72e
Compare
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
notes-management-filters
branch
from
f356aac to
48fdc88
Compare
x-pack/plugins/security_solution/public/notes/components/add_note.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
force-pushed
the
notes-management-filters
branch
2 times, most recently
from
5663352 to
434ff00
Compare
logeekal
reviewed
Oct 14, 2024
x-pack/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts
Outdated
Show resolved
Hide resolved
1 task
PhilippeOberti
force-pushed
the
notes-management-filters
branch
4 times, most recently
from
07cc8a7 to
34b17f9
Compare
janmonschke
reviewed
Oct 15, 2024
x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml
Outdated
Show resolved
Hide resolved
janmonschke
approved these changes
Oct 15, 2024
PhilippeOberti
force-pushed
the
notes-management-filters
branch
from
66eac65 to
2e3b153
Compare
…cument only, saved object only, both or none
PhilippeOberti
force-pushed
the
notes-management-filters
branch
from
2e3b153 to
f8810f8
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
…stic#195501) (cherry picked from commit 66708b2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
#195501) (#196508) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - allow filtering by note association (#195501)](#195501) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T09:32:51Z","message":"[Security Solution][Notes] - allow filtering by note association (#195501)","sha":"66708b26c5dd2918692d77da81edcd1d3836cec5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - allow filtering by note association","number":195501,"url":"https://github.com/elastic/kibana/pull/195501","mergeCommit":{"message":"[Security Solution][Notes] - allow filtering by note association (#195501)","sha":"66708b26c5dd2918692d77da81edcd1d3836cec5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195501","number":195501,"mergeCommit":{"message":"[Security Solution][Notes] - allow filtering by note association (#195501)","sha":"66708b26c5dd2918692d77da81edcd1d3836cec5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
PhilippeOberti
added a commit
that referenced
this pull request
Oct 18, 2024
…ement page, an enum value was missing from the api (#196912) ## Summary _**Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly**_ This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent [PR](#195501). Current notes management borken page  This is the error in the network tab  This PR fixes the issue  --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ement page, an enum value was missing from the api (elastic#196912) ## Summary _**Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly**_ This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent [PR](elastic#195501). Current notes management borken page  This is the error in the network tab  This PR fixes the issue  --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit bf7c5aa)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ement page, an enum value was missing from the api (elastic#196912) ## Summary _**Notes: please ignore the spaces introduced in the first commit, Webstorm is trying to be smart... CI should take care of fixing that in a second commit shortly**_ This PR fixes a small issue that prevents the notes management page to load. The issue comes from the fact that one of the enum values passed to filter notes was missing from the open api spec. This issue was introduced in this recent [PR](elastic#195501). Current notes management borken page  This is the error in the network tab  This PR fixes the issue  --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit bf7c5aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a filter to the Notes management page, to allow users to filter by the following:
Screen.Recording.2024-10-16.at.12.03.44.AM.mov
The server side code has been updated to handle having this new filter working in combination with the existing user filter added in this previous PR.
API integration tests have been added to test the new functionality.
#193086
Checklist