-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lens esql generation #196049
lens esql generation #196049
Conversation
ab81587
to
02b4ce9
Compare
a152a67
to
a097d5d
Compare
src/plugins/data/common/datatable_utilities/datatable_utilities_service.ts
Outdated
Show resolved
Hide resolved
5243363
to
3dcccc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Peter, LGTM!
Is this the first use of the Feature Flags service? Nice! 🙌 |
config/kibana.yml
Outdated
feature_flags.overrides: | ||
lens.enable_esql: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remember to remove this before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just added in the commit named revert before merging
to check once again that CI is passing when this flag is on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming! I'm sure that Core won't be needed when this is removed :)
Core review won't be needed when the changes to kibana.yml
are removed
This reverts commit b4555d3.
as expected rollup and search sessions tests fail when turning the flag on, everything else passes |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
updates lens so it uses ESQL when requesting data from elasticsearch rather than DSL when that is possible.
nothing should change for the user, everything should work exactly as before
but when going to inspector you will be able to see that in some cases we will send out ESQL request.
the feature is only enabled when the
lens.enable_esql
feature flag is enabled.at the moment this covers very few cases, but rather builds the necessary infrastructure so we can keep improving this over time:
how to test:
kibana.dev.yaml
:products.price
todo: