-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Authz] Superuser privileges #196586
[Authz] Superuser privileges #196586
Conversation
1d158a0
to
a516b7d
Compare
a516b7d
to
6055522
Compare
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core HTTP router changes LGTM!
ACK: will review tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
x-pack/plugins/encrypted_saved_objects/server/routes/key_rotation.test.ts
Show resolved
Hide resolved
packages/core/http/core-http-router-server-internal/src/security_route_config_validator.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/authorization/api_authorization.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/authorization/api_authorization.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
…bana into 196271-superuser-access
💚 Build Succeeded
Metrics [docs]History
|
Starting backport for target branches: 8.x |
## Summary This PR adds support for explicit indication whether endpoint is restricted to superusers only. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the new configuration. __Relates: https://github.com/elastic/kibana/issues/196271__ ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Release note Introduced explicit configuration for routes that require superuser access. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the new configuration. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 598706c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Authz] Superuser privileges (#196586)](#196586) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T07:39:49Z","message":"[Authz] Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support for explicit indication whether endpoint is\r\nrestricted to superusers only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the new\r\nconfiguration.\r\n\r\n__Relates: https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n## Release note\r\n\r\nIntroduced explicit configuration for routes that require superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the\r\nnew configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Security","Feature:Security/Authorization","v9.0.0","backport:prev-minor"],"title":"[Authz] Superuser privileges","number":196586,"url":"https://github.com/elastic/kibana/pull/196586","mergeCommit":{"message":"[Authz] Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support for explicit indication whether endpoint is\r\nrestricted to superusers only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the new\r\nconfiguration.\r\n\r\n__Relates: https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n## Release note\r\n\r\nIntroduced explicit configuration for routes that require superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the\r\nnew configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196586","number":196586,"mergeCommit":{"message":"[Authz] Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support for explicit indication whether endpoint is\r\nrestricted to superusers only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the new\r\nconfiguration.\r\n\r\n__Relates: https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n## Release note\r\n\r\nIntroduced explicit configuration for routes that require superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the\r\nnew configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35"}}]}] BACKPORT--> Co-authored-by: Elena Shostak <[email protected]>
Summary
This PR adds support for explicit indication whether endpoint is restricted to superusers only.
Moved
api/encrypted_saved_objects/_rotate_key
endpoint to the new configuration.Relates: #196271
Checklist
Release note
Introduced explicit configuration for routes that require superuser access. Moved
api/encrypted_saved_objects/_rotate_key
endpoint to the new configuration.