Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authz] Superuser privileges #196586

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented Oct 16, 2024

Summary

This PR adds support for explicit indication whether endpoint is restricted to superusers only.
Moved api/encrypted_saved_objects/_rotate_key endpoint to the new configuration.

Relates: #196271

Checklist

Release note

Introduced explicit configuration for routes that require superuser access. Moved api/encrypted_saved_objects/_rotate_key endpoint to the new configuration.

@elena-shostak elena-shostak force-pushed the 196271-superuser-access branch from 1d158a0 to a516b7d Compare October 16, 2024 17:54
@elena-shostak elena-shostak force-pushed the 196271-superuser-access branch from a516b7d to 6055522 Compare October 17, 2024 09:34
@elena-shostak elena-shostak added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:enhancement Feature:Security/Authorization Platform Security - Authorization labels Oct 17, 2024
@elena-shostak elena-shostak marked this pull request as ready for review October 17, 2024 15:22
@elena-shostak elena-shostak requested review from a team as code owners October 17, 2024 15:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from azasypkin October 17, 2024 15:28
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core HTTP router changes LGTM!

@elena-shostak elena-shostak added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 18, 2024
@azasypkin
Copy link
Member

ACK: will review tomorrow

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
@kbn/core-http-server 533 534 +1

History

@elena-shostak elena-shostak merged commit 598706c into elastic:main Oct 23, 2024
27 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11475300741

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
## Summary

This PR adds support for explicit indication whether endpoint is
restricted to superusers only.
Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the new
configuration.

__Relates: https://github.com/elastic/kibana/issues/196271__

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

## Release note

Introduced explicit configuration for routes that require superuser
access. Moved `api/encrypted_saved_objects/_rotate_key` endpoint to the
new configuration.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 598706c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 23, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Authz] Superuser privileges
(#196586)](#196586)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T07:39:49Z","message":"[Authz]
Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support
for explicit indication whether endpoint is\r\nrestricted to superusers
only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the
new\r\nconfiguration.\r\n\r\n__Relates:
https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\n\r\nIntroduced explicit configuration for routes that require
superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key`
endpoint to the\r\nnew
configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Security","Feature:Security/Authorization","v9.0.0","backport:prev-minor"],"title":"[Authz]
Superuser
privileges","number":196586,"url":"https://github.com/elastic/kibana/pull/196586","mergeCommit":{"message":"[Authz]
Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support
for explicit indication whether endpoint is\r\nrestricted to superusers
only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the
new\r\nconfiguration.\r\n\r\n__Relates:
https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\n\r\nIntroduced explicit configuration for routes that require
superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key`
endpoint to the\r\nnew
configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196586","number":196586,"mergeCommit":{"message":"[Authz]
Superuser privileges (#196586)\n\n## Summary\r\n\r\nThis PR adds support
for explicit indication whether endpoint is\r\nrestricted to superusers
only.\r\nMoved `api/encrypted_saved_objects/_rotate_key` endpoint to the
new\r\nconfiguration.\r\n\r\n__Relates:
https://github.com/elastic/kibana/issues/196271__\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\n\r\nIntroduced explicit configuration for routes that require
superuser\r\naccess. Moved `api/encrypted_saved_objects/_rotate_key`
endpoint to the\r\nnew
configuration.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"598706c7d1d171bf7012e91d1389ade9734e8b35"}}]}]
BACKPORT-->

Co-authored-by: Elena Shostak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Security/Authorization Platform Security - Authorization release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants