-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Granular Connector RBAC #197346
[POC] Granular Connector RBAC #197346
Conversation
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Hi @doakalexi , ✅ If user does not have the new sub-privilage, they can't execute the test or connector actions via APII also noticed that the new Sub-Privilege can be set for either ✅ Kibana Stack Connectors API prevents execution of connector sub-actions✅ Response Actions from the security app can be executed if user has the EDR sub-privilegeI validate that a user can send response actions to SentinelOne and those actions complete as expected... this validate not only that the user can execute the connector's sub-actions that are not accessible via the Stack Connector's Kibana API, but also that the background task - which uses an un-privileged Sub-Actions client - can utilize the connector. ✅ User is provided an error in the Security console if they do not have the EDR sub-privilege✅ The connector is not displayed or available for conjuration/use on SIEM Alert Rules |
Towards #194618
Summary
This PoC creates a new EDR connector subfeature privilege under the read privilege for connectors. The read privilege currently allows users to execute connectors, and this new privilege will limit some of the connectors that can be executed. When the EDR privilege is turned on, users will be able to execute EDR connectors, and when it is off they will not execute.
To determine which connectors are considered EDR connectors, this PoC leverages
getKibanaPrivileges
in the connector type definition. I removed the restrictions to use this field only for system actions and renamedgetSystemActionKibanaPrivileges
togetActionKibanaPrivileges
. I also added a field,isEdrActionType
, to the connector type definition to help disable testing/executing an EDR connector in the ui.Below are some other changes we made after initial feedback for the PoC.
EDR Connector Execution for Testing
The execution of EDR connectors in Stack Management is limited to a single sub-action for testing purposes. This ensures users can still configure/test EDR connectors. For the PoC, the SentinelOne params UI has been reintroduced with options restricted to one sub-action. In the final implementation, the UIs for all EDR connectors should be restored.
Rule API and Feature Configuration Updates
isBidirectionalConnectorType
check inaction_type_registry.ts
. Instead, I removedSecurityConnectorFeatureId
from thesupportedFeatureIds
of the SentinelOne connector type definition.To test
EDR Connector Subfeature Privilege
elastic
user that has super privileges.EDR Connector Execution for Testing
getAgents
sub-actiongetAgents
sub-action. (It will fail but verify it's notUnauthorized
)subAction
withisolateHost
. Verify that you get an unauthorized error.Rule API and Feature Configuration Updates