-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Hide field statistics tab and Dashboard when ES|QL is in use, disable Index data visualizer for MATCH and QSRT functions #197538
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f5fa6c6
Add getFieldStatsWarningMsgForQuery
qn895 8736c72
Add messaging for embeddables
qn895 b35e69c
Update messaging and add callout
qn895 2957796
Update callout style with icon
qn895 aff1b6f
Update styling
qn895 a6145ce
Make it so preview won't happen if not supported
qn895 ae086fc
Update messaging
qn895 1f9cef4
Exit early
qn895 38d47b9
Add new util to esql-utils
qn895 fafcc26
Merge remote-tracking branch 'upstream/main' into esql-match-disable
qn895 db63c8b
Merge branch 'main' into esql-match-disable
stratoula b2b7222
Refactor to have separate messaging for field stats, change from call…
qn895 7321cf5
Remove unused constants
qn895 4215c9c
Refactor
qn895 347e1ec
:Merge remote-tracking branch 'upstream/main' into esql-match-disable
qn895 989a523
Fix test
qn895 2dd74e9
Fix logic for detecting function
qn895 3ec8263
Update tests
qn895 cd06f88
Merge remote-tracking branch 'upstream/main' into esql-match-disable
qn895 2c4f740
Fix undefined
qn895 0dfc116
Remove field stats tab in ES|QL mode for Discover & dashboard, redire…
qn895 881e57b
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 7ea2efb
Update tests
qn895 b3c356e
Revert field list changes
qn895 bafff15
Add view mode
qn895 a8cd5be
Update tests
qn895 6b7ee45
Consolidate messaging style
qn895 dc99c68
Consolidate messaging
qn895 9d4f0f1
Update types
qn895 eabc053
Update logic for toggle when opening saved search
qn895 62c5496
Merge remote-tracking branch 'upstream/main' into esql-match-disable
qn895 5ccbdf7
More test updates
qn895 47f6210
Update jest test
qn895 ed826d0
Fix data visualizer page
qn895 5cf259a
Merge remote-tracking branch 'upstream/main' into esql-match-disable
qn895 2f2b2fb
Merge branch 'main' into esql-match-disable
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update styling
- Loading branch information
commit aff1b6f8d5d439cb52c148675d5bd5385455e078
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...ic/application/index_data_visualizer/embeddables/grid_embeddable/embeddable_error_msg.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
import React from 'react'; | ||
import { EuiEmptyPrompt, EuiIcon, useEuiTheme } from '@elastic/eui'; | ||
import { EmptyPlaceholder } from '@kbn/charts-plugin/public'; | ||
import { i18n } from '@kbn/i18n'; | ||
import { css } from '@emotion/react'; | ||
import type { FieldStatisticTableEmbeddableProps } from './types'; | ||
const FIELD_STATS_UNAVAILABLE_TITLE = i18n.translate( | ||
'xpack.dataVisualizer.fieldStats.unavailableTitle', | ||
{ | ||
defaultMessage: 'Field statistics unavailable', | ||
} | ||
); | ||
export const FieldStatsUnavailableMessage = ({ | ||
id, | ||
content, | ||
title = FIELD_STATS_UNAVAILABLE_TITLE, | ||
}: Pick<FieldStatisticTableEmbeddableProps, 'id'> & { content: string; title?: string }) => { | ||
const { euiTheme } = useEuiTheme(); | ||
if (!content) return null; | ||
|
||
if (id === 'dashboard_embeddable') { | ||
return <EmptyPlaceholder icon={'warning'} message={title} />; | ||
} | ||
return ( | ||
<EuiEmptyPrompt | ||
icon={<EuiIcon size="l" type="warning" color="warning" />} | ||
color="plain" | ||
paddingSize="m" | ||
css={css` | ||
margin: ${euiTheme.size.xl} auto; | ||
`} | ||
title={<h2 data-test-subj="fieldStatsUnavailableCalloutTitle">{title}</h2>} | ||
titleSize="xs" | ||
hasBorder | ||
body={<>{content}</>} | ||
/> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I exported a saved search SO from another branch, imported it and added to a Dashboard. For some reason, it only shows a loading indicator:

test_match.ndjson.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing that! This seems out of scope for this PR so I'll address it in a different follow up.