Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: [Stateful:Connectors:New connector page]Configuration form missing instructions and field names from announcement (#197963) #198021

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[8.x] fix: [Stateful:Connectors:New connector page]Configuration form missing instructions and field names from announcement (#197963) #198021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/kbn-search-connectors/components/configuration/connector_configuration_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const ConfigInputField: React.FC<ConfigInputFieldProps> = ({
isLoading,
validateAndSetConfigValue,
}) => {
const { isValid, required, placeholder, value } = configEntry;
const { isValid, required, placeholder, value, label } = configEntry;
const [innerValue, setInnerValue] = useState(value);
return (
<EuiFieldText
Expand All @@ -65,6 +65,7 @@ export const ConfigInputField: React.FC<ConfigInputFieldProps> = ({
validateAndSetConfigValue(event.target.value);
}}
placeholder={placeholder}
aria-label={label}
/>
);
};
Expand All @@ -74,7 +75,7 @@ export const ConfigInputTextArea: React.FC<ConfigInputFieldProps> = ({
configEntry,
validateAndSetConfigValue,
}) => {
const { isValid, required, placeholder, value } = configEntry;
const { isValid, required, placeholder, value, label } = configEntry;
const [innerValue, setInnerValue] = useState(value);
return (
<EuiTextArea
Expand All @@ -88,6 +89,7 @@ export const ConfigInputTextArea: React.FC<ConfigInputFieldProps> = ({
validateAndSetConfigValue(event.target.value);
}}
placeholder={placeholder}
aria-label={label}
/>
);
};
Expand Down Expand Up @@ -129,7 +131,7 @@ export const ConfigInputPassword: React.FC<ConfigInputFieldProps> = ({
configEntry,
validateAndSetConfigValue,
}) => {
const { required, value } = configEntry;
const { required, value, label } = configEntry;
const [innerValue, setInnerValue] = useState(value);
return (
<EuiFieldPassword
Expand All @@ -141,6 +143,7 @@ export const ConfigInputPassword: React.FC<ConfigInputFieldProps> = ({
setInnerValue(event.target.value);
validateAndSetConfigValue(event.target.value);
}}
aria-label={label}
/>
);
};
Expand Down Expand Up @@ -170,6 +173,7 @@ export const ConnectorConfigurationField: React.FC<ConnectorConfigurationFieldPr
onChange={(event) => {
validateAndSetConfigValue(event.target.value);
}}
aria-label={label}
/>
) : (
<EuiRadioGroup
Expand All @@ -180,6 +184,7 @@ export const ConnectorConfigurationField: React.FC<ConnectorConfigurationFieldPr
onChange={(id) => {
validateAndSetConfigValue(id);
}}
aria-label={label}
/>
);

Expand Down Expand Up @@ -227,6 +232,7 @@ export const ConnectorConfigurationField: React.FC<ConnectorConfigurationFieldPr
onChange={(event) => {
validateAndSetConfigValue(event.target.checked);
}}
aria-label={label}
/>
</EuiFlexItem>
{!hasPlatinumLicense && (
Expand Down