[SecuritySolution][ProductFeatures] Add support for security.authz.requiredPrivileges for the API auth control
#198312
+327
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
| const disabled = authz.requiredPrivileges.some((privilegeEntry) => { | ||
| if (typeof privilegeEntry === 'object') { | ||
| if (privilegeEntry.allRequired) { | ||
| if (privilegeEntry.allRequired.some(isApiPrivilegeSecurityAndDisabled)) { |
There was a problem hiding this comment.
It should be used visa versa, privilegeEntry.allRequired.every and privilegeEntry.anyRequired.some
There was a problem hiding this comment.
I am finding disabled actions, so I use the oposite operation. This approach allows me to check the privilege is a security solution action and is disabled, at the same time.
You can take a look at the test for examples
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
angorayc
reviewed
Oct 31, 2024
| const API_ACTION_TAG_PREFIX = `access:${APP_ID}-`; | ||
|
|
||
| const isAuthzEnabled = (authz?: RecursiveReadonly<RouteAuthz>): authz is AuthzEnabled => { | ||
| return Boolean((authz as AuthzEnabled)?.requiredPrivileges); |
There was a problem hiding this comment.
Would like to know what's the difference between security.authz.requiredFeatures and security.authz.requiredPrivileges?
There was a problem hiding this comment.
Sorry, the PR title was wrong, the correct entry is security.authz.requiredPrivileges, security.authz.requiredFeatures does not exist
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
cc @semd |
semd
changed the title
security.authz.requiredFeatures for the API auth controlsecurity.authz.requiredPrivileges for the API auth control
angorayc
approved these changes
Oct 31, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
…equiredPrivileges` for the API auth control (elastic#198312) ## Summary Adds support for the new API routes security authorization properties ([docs](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization)) to the `ProductFeaturesService` API authorization control Closes: elastic#194445 Related: elastic#184674 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 42e978b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
…ity.authz.requiredPrivileges` for the API auth control (#198312) (#198566) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution][ProductFeatures] Add support for `security.authz.requiredPrivileges` for the API auth control (#198312)](#198312) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T15:31:00Z","message":"[SecuritySolution][ProductFeatures] Add support for `security.authz.requiredPrivileges` for the API auth control (#198312)\n\n## Summary\r\n\r\nAdds support for the new API routes security authorization properties\r\n([docs](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization))\r\nto the `ProductFeaturesService` API authorization control\r\n\r\nCloses: https://github.com/elastic/kibana/issues/194445\r\n\r\nRelated: https://github.com/elastic/kibana/issues/184674\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"42e978be21bc7c85fc09f46213c194b89209690f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","v8.17.0"],"title":"[SecuritySolution][ProductFeatures] Add support for `security.authz.requiredPrivileges` for the API auth control","number":198312,"url":"https://github.com/elastic/kibana/pull/198312","mergeCommit":{"message":"[SecuritySolution][ProductFeatures] Add support for `security.authz.requiredPrivileges` for the API auth control (#198312)\n\n## Summary\r\n\r\nAdds support for the new API routes security authorization properties\r\n([docs](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization))\r\nto the `ProductFeaturesService` API authorization control\r\n\r\nCloses: https://github.com/elastic/kibana/issues/194445\r\n\r\nRelated: https://github.com/elastic/kibana/issues/184674\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"42e978be21bc7c85fc09f46213c194b89209690f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198312","number":198312,"mergeCommit":{"message":"[SecuritySolution][ProductFeatures] Add support for `security.authz.requiredPrivileges` for the API auth control (#198312)\n\n## Summary\r\n\r\nAdds support for the new API routes security authorization properties\r\n([docs](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization))\r\nto the `ProductFeaturesService` API authorization control\r\n\r\nCloses: https://github.com/elastic/kibana/issues/194445\r\n\r\nRelated: https://github.com/elastic/kibana/issues/184674\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"42e978be21bc7c85fc09f46213c194b89209690f"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
…equiredPrivileges` for the API auth control (elastic#198312) ## Summary Adds support for the new API routes security authorization properties ([docs](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization)) to the `ProductFeaturesService` API authorization control Closes: elastic#194445 Related: elastic#184674 --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the new API routes security authorization properties (docs) to the
ProductFeaturesServiceAPI authorization controlCloses: #194445
Related: #184674