[Console] Fix actions menu scrolling issue #200018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Console
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
approved these changes
Nov 14, 2024
|
/ci |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @sabarasaba |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2024
(cherry picked from commit 0ed8230)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Console] Fix actions menu scrolling issue (#200018)](#200018) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-17T11:44:07Z","message":"[Console] Fix actions menu scrolling issue (#200018)","sha":"0ed82309e22a7fc8ac067c1dbf2c378735f86855","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console] Fix actions menu scrolling issue","number":200018,"url":"https://github.com/elastic/kibana/pull/200018","mergeCommit":{"message":"[Console] Fix actions menu scrolling issue (#200018)","sha":"0ed82309e22a7fc8ac067c1dbf2c378735f86855"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200018","number":200018,"mergeCommit":{"message":"[Console] Fix actions menu scrolling issue (#200018)","sha":"0ed82309e22a7fc8ac067c1dbf2c378735f86855"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #197965
Summary
Make sure that the offset never goes into negative so that if a request is long enough, the actions menu remains anchored at the top of the editor.