Obs AI Assistant Fetch user instructions using user_id #200137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturoliduena
added
release_note:fix
backport:prev-minor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
approved these changes
Nov 18, 2024
arturoliduena
force-pushed
the
192701-Obs-AI-Assistant-get-user-instructions-by-id
branch
from
2cbe5be to
791b51c
Compare
… for knowledge base instructions
arturoliduena
force-pushed
the
192701-Obs-AI-Assistant-get-user-instructions-by-id
branch
from
6523db4 to
cc23a7c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
## Summary [Obs AI Assistant] Fetch user instructions using id instead of username for knowledge base instructions elastic#192701 To avoid potential collisions when fetching data, we should query for the user id instead of the user name when getting instructions. (cherry picked from commit 518dc25)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
#200759) # Backport This will backport the following commits from `main` to `8.x`: - [Obs AI Assistant Fetch user instructions using user_id (#200137)](#200137) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Arturo Lidueña","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T15:16:32Z","message":"Obs AI Assistant Fetch user instructions using user_id (#200137)\n\n## Summary\r\n\r\n[Obs AI Assistant] Fetch user instructions using id instead of username\r\nfor knowledge base instructions #192701\r\n\r\nTo avoid potential collisions when fetching data, we should query for\r\nthe user id instead of the user name when getting instructions.","sha":"518dc2591f845b9e0772d367f71065cd787ad9bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"Obs AI Assistant Fetch user instructions using user_id ","number":200137,"url":"https://github.com/elastic/kibana/pull/200137","mergeCommit":{"message":"Obs AI Assistant Fetch user instructions using user_id (#200137)\n\n## Summary\r\n\r\n[Obs AI Assistant] Fetch user instructions using id instead of username\r\nfor knowledge base instructions #192701\r\n\r\nTo avoid potential collisions when fetching data, we should query for\r\nthe user id instead of the user name when getting instructions.","sha":"518dc2591f845b9e0772d367f71065cd787ad9bf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200137","number":200137,"mergeCommit":{"message":"Obs AI Assistant Fetch user instructions using user_id (#200137)\n\n## Summary\r\n\r\n[Obs AI Assistant] Fetch user instructions using id instead of username\r\nfor knowledge base instructions #192701\r\n\r\nTo avoid potential collisions when fetching data, we should query for\r\nthe user id instead of the user name when getting instructions.","sha":"518dc2591f845b9e0772d367f71065cd787ad9bf"}}]}] BACKPORT--> Co-authored-by: Arturo Lidueña <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
## Summary [Obs AI Assistant] Fetch user instructions using id instead of username for knowledge base instructions elastic#192701 To avoid potential collisions when fetching data, we should query for the user id instead of the user name when getting instructions.
sorenlouv
reviewed
Dec 3, 2024
Comment on lines
+161
to
+165
| await supertestWithoutAuth | ||
| .post(endpoint) | ||
| .set('kbn-xsrf', 'xxx') | ||
| .set('Cookie', cookie) | ||
| .send(params.body); |
There was a problem hiding this comment.
@arturoliduena Just noticed this while looking at @viduni94's PR. We should aim to use observabilityAIAssistantAPIClient when possible because it comes with type safety, making it easier to use, and "fails faster" when an endpoint is changed:
const fullConversation = await observabilityAIAssistantAPIClient.noAuth({
endpoint: "GET /internal/observability_ai_assistant/conversation",
params: {
// ...
},
});noAuth user doesn't exist but can be created here
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary [Obs AI Assistant] Fetch user instructions using id instead of username for knowledge base instructions elastic#192701 To avoid potential collisions when fetching data, we should query for the user id instead of the user name when getting instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[Obs AI Assistant] Fetch user instructions using id instead of username for knowledge base instructions #192701
To avoid potential collisions when fetching data, we should query for the user id instead of the user name when getting instructions.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_node:*label is applied per the guidelines