[ResponseOps][Cases] Remove deprecated date format from telemetry #200331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
added
the
release_note:skip
adcoelho
approved these changes
Nov 18, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @cnasikas |
|
Starting backport for target branches: 8.18, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
…astic#200331) ## Summary The Cases telemetry uses a deprecated date format that will not be supported in 9.0. This PR changes the format of the date set in the `format` field as suggested here https://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23. Specifically, it changes `Y` to `y`. From the docs: > In particular, if you are using the Y specifier as part of a calendar date format, you are probably using it erroneously; Joda time uses Y to represent year-of-era, but the JDK uses Y to represent week-years. You need to modify your format to use y instead, or change to a built-in format. Fixes: elastic/kibana-team#1188 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7ace262)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
…ry (#200331) (#200658) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Remove deprecated date format from telemetry (#200331)](#200331) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T22:30:16Z","message":"[ResponseOps][Cases] Remove deprecated date format from telemetry (#200331)\n\n## Summary\r\n\r\nThe Cases telemetry uses a deprecated date format that will not be\r\nsupported in 9.0. This PR changes the format of the date set in the\r\n`format` field as suggested here\r\nhttps://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23.\r\nSpecifically, it changes `Y` to `y`. From the docs:\r\n\r\n> In particular, if you are using the Y specifier as part of a calendar\r\ndate format, you are probably using it erroneously; Joda time uses Y to\r\nrepresent year-of-era, but the JDK uses Y to represent week-years. You\r\nneed to modify your format to use y instead, or change to a built-in\r\nformat.\r\n\r\nFixes: https://github.com/elastic/kibana-team/issues/1188\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7ace26213d6e7e493144c70a4f408cb9939d1fb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[ResponseOps][Cases] Remove deprecated date format from telemetry","number":200331,"url":"https://github.com/elastic/kibana/pull/200331","mergeCommit":{"message":"[ResponseOps][Cases] Remove deprecated date format from telemetry (#200331)\n\n## Summary\r\n\r\nThe Cases telemetry uses a deprecated date format that will not be\r\nsupported in 9.0. This PR changes the format of the date set in the\r\n`format` field as suggested here\r\nhttps://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23.\r\nSpecifically, it changes `Y` to `y`. From the docs:\r\n\r\n> In particular, if you are using the Y specifier as part of a calendar\r\ndate format, you are probably using it erroneously; Joda time uses Y to\r\nrepresent year-of-era, but the JDK uses Y to represent week-years. You\r\nneed to modify your format to use y instead, or change to a built-in\r\nformat.\r\n\r\nFixes: https://github.com/elastic/kibana-team/issues/1188\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7ace26213d6e7e493144c70a4f408cb9939d1fb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200331","number":200331,"mergeCommit":{"message":"[ResponseOps][Cases] Remove deprecated date format from telemetry (#200331)\n\n## Summary\r\n\r\nThe Cases telemetry uses a deprecated date format that will not be\r\nsupported in 9.0. This PR changes the format of the date set in the\r\n`format` field as suggested here\r\nhttps://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23.\r\nSpecifically, it changes `Y` to `y`. From the docs:\r\n\r\n> In particular, if you are using the Y specifier as part of a calendar\r\ndate format, you are probably using it erroneously; Joda time uses Y to\r\nrepresent year-of-era, but the JDK uses Y to represent week-years. You\r\nneed to modify your format to use y instead, or change to a built-in\r\nformat.\r\n\r\nFixes: https://github.com/elastic/kibana-team/issues/1188\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7ace26213d6e7e493144c70a4f408cb9939d1fb0"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christos Nasikas <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…astic#200331) ## Summary The Cases telemetry uses a deprecated date format that will not be supported in 9.0. This PR changes the format of the date set in the `format` field as suggested here https://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23. Specifically, it changes `Y` to `y`. From the docs: > In particular, if you are using the Y specifier as part of a calendar date format, you are probably using it erroneously; Joda time uses Y to represent year-of-era, but the JDK uses Y to represent week-years. You need to modify your format to use y instead, or change to a built-in format. Fixes: elastic/kibana-team#1188 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Cases telemetry uses a deprecated date format that will not be supported in 9.0. This PR changes the format of the date set in the
formatfield as suggested here https://www.elastic.co/blog/locale-changes-elasticsearch-8-16-jdk-23. Specifically, it changesYtoy. From the docs:Fixes: https://github.com/elastic/kibana-team/issues/1188
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.