Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804) #200506

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

machadoum
Copy link
Member

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Pablo Machado "}},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

…ement flyout (elastic#199804)

## Summary

The entity analytics enablement model doesn't show the missing
privileges warning for the Entity Risk score.

To fix it, I added to the model the same callout we display on the risk
engine page.

### What is not included
* Improvement to the risk engine callout
* Fix risk engine callout bugs
elastic/security-team#11138

### How to test it
* Create a user with no privileges except to the security solution app
and the `logs*` index
* Login and open the entity analytics page with the non-privileged user
* Click enable and check if the model displays the missing privileges
callout for the risk engine

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 54c6144)

# Conflicts:
#	x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.test.tsx
#	x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
@machadoum
Copy link
Member Author

I removed the tests from 8.16 because the test file doesn't exist.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +171.0B

History

@machadoum machadoum merged commit c77b1b6 into elastic:8.16 Nov 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants