-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spaces] Moved tests to agnostic setup #200606
base: main
Are you sure you want to change the base?
Changes from 28 commits
5f94ea3
6b93044
3ec74cd
2cec1ea
1231e09
3d9b71a
20f2a1a
25619ec
c9efafc
ffa165a
99e4827
a719a87
1e5ec58
ffb4dfe
132189d
3b2cad8
85a080b
1a54a19
0e4c336
50cbe35
e82dcfe
f292abc
ef9730d
78a31e8
2fdb153
e85a5ca
912fe47
424d9d3
c91bfc0
1d1e6b8
7d68cd6
f4b09c7
6f5f03c
89482c1
4f21b9e
e8c8bfc
ea7beae
5e7de03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,3 +128,65 @@ system_indices_superuser: | |
privileges: ['*'] | ||
resources: ['*'] | ||
run_as: ['*'] | ||
|
||
machine_learning_admin: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These roles are built-in to stateful, but not serverless. The predefined serverless roles can be found in the Any tests that need a role other than these built-in serveless roles, will require a custom role, and will not be able to run on MKI from the FTR (at least for the time being, as it is not yet supported). The stateful roles file is meant to mirror the serverless roles to keep the testing methodology the same. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, I will move it to custom role There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. UPD: we cannot use our api for custom roles or at least I don't see how. All those 3 roles rely on reserved built in privileges: I've moved those 3 tests to only stateful for now. |
||
cluster: ['manage_ml'] | ||
indices: | ||
- names: ['.ml-anomalies*','.ml-notifications*','.ml-state*','.ml-meta*','.ml-stats-*'] | ||
privileges: ['view_index_metadata', 'read'] | ||
allow_restricted_indices: true | ||
- names: ['.ml-annotations*'] | ||
privileges: ['write', 'read', 'view_index_metadata'] | ||
allow_restricted_indices: true | ||
applications: | ||
- application: 'kibana-*' | ||
privileges: ['reserved_ml_admin'] | ||
resources: ['*'] | ||
run_as: [] | ||
|
||
machine_learning_user: | ||
cluster: ['monitor_ml'] | ||
indices: | ||
- names: ['.ml-anomalies*','.ml-notifications*',] | ||
privileges: ['view_index_metadata', 'read'] | ||
allow_restricted_indices: false | ||
- names: ['.ml-annotations*'] | ||
privileges: ['write', 'read', 'view_index_metadata'] | ||
allow_restricted_indices: false | ||
applications: | ||
- application: 'kibana-*' | ||
privileges: ['reserved_ml_user'] | ||
resources: ['*'] | ||
run_as: [] | ||
|
||
monitoring_user: | ||
cluster: | ||
- "cluster:monitor/main" | ||
- "cluster:monitor/xpack/info" | ||
- "cluster:monitor/remote/info" | ||
indices: | ||
- names: | ||
- ".monitoring-*" | ||
privileges: | ||
- "read" | ||
- "read_cross_cluster" | ||
allow_restricted_indices: false | ||
- names: | ||
- "/metrics-(beats|elasticsearch|enterprisesearch|kibana|logstash).*/" | ||
privileges: | ||
- "read" | ||
- "read_cross_cluster" | ||
allow_restricted_indices: false | ||
- names: | ||
- "metricbeat-*" | ||
privileges: | ||
- "read" | ||
- "read_cross_cluster" | ||
allow_restricted_indices: false | ||
applications: | ||
- application: "kibana-*" | ||
privileges: | ||
- "reserved_monitoring" | ||
resources: | ||
- "*" | ||
run_as: [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,5 +34,11 @@ module.exports = { | |
'@typescript-eslint/no-floating-promises': 'error', | ||
}, | ||
}, | ||
{ | ||
files: ['*spaces_api_integration/common/services/basic_auth_supertest.ts'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agent.auth(this.user.username!, this.user.password!); Needed to suppress the eslint error for this line in our custom test service, the promise is awaited in the tests itself and adding a
|
||
rules: { | ||
'@typescript-eslint/no-floating-promises': 'off', | ||
}, | ||
}, | ||
], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed it with @azasypkin and @jeramysoucy , that while
basic
license is stateful-only, these tests cannot be considered deployment-agnostic. wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move them out of the
deployment_agnostic
folder to eliminate confusion, but all those tests still use the same test suite the serverless/trial config does