Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Anomaly Detection anomaly charts: remove filter icons for charts displayed in cases #200821

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Nov 19, 2024

Summary

Fixes #199549

This PR hides the filter icons for anomaly charts embeddable in cases as they do not have any functionality there.

Cases:
image

Dashboards:
image

explorer:
image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_node:* label is applied per the guidelines

@alvarezmelissa87 alvarezmelissa87 added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.17.0 labels Nov 19, 2024
@alvarezmelissa87 alvarezmelissa87 self-assigned this Nov 19, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner November 19, 2024 21:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🚀

@alvarezmelissa87
Copy link
Contributor Author

/ci

@peteharverson peteharverson changed the title [ML] Anomaly Detection anomaly charts: remove filter icons for charts displayed in cases [ML] Anomaly Detection anomaly charts: removes filter icons for charts displayed in cases Nov 21, 2024
@peteharverson peteharverson changed the title [ML] Anomaly Detection anomaly charts: removes filter icons for charts displayed in cases [ML] Anomaly Detection anomaly charts: remove filter icons for charts displayed in cases Nov 21, 2024
@alvarezmelissa87
Copy link
Contributor Author

/ci

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

/ci

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.7MB 4.7MB +235.0B

History

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit f635b32 into elastic:main Nov 26, 2024
21 checks passed
@alvarezmelissa87 alvarezmelissa87 deleted the ml-anomaly-charts-icons-in-cases branch November 26, 2024 18:37
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12036937240

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
… displayed in cases (elastic#200821)

## Summary

Fixes elastic#199549

This PR hides the filter icons for anomaly charts embeddable in cases as
they do not have any functionality there.

Cases:
<img width="947" alt="image"
src="https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c">

Dashboards:
<img width="737" alt="image"
src="https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08">

explorer:
<img width="1089" alt="image"
src="https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170">

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit f635b32)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
… displayed in cases (elastic#200821)

## Summary

Fixes elastic#199549

This PR hides the filter icons for anomaly charts embeddable in cases as
they do not have any functionality there.

Cases:
<img width="947" alt="image"
src="https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c">

Dashboards:
<img width="737" alt="image"
src="https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08">

explorer:
<img width="1089" alt="image"
src="https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170">

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit f635b32)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 26, 2024
… charts displayed in cases (#200821) (#201854)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[ML] Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases
(#200821)](#200821)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T18:36:58Z","message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in
cases","number":200821,"url":"https://github.com/elastic/kibana/pull/200821","mergeCommit":{"message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200821","number":200821,"mergeCommit":{"message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 26, 2024
…charts displayed in cases (#200821) (#201855)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases
(#200821)](#200821)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T18:36:58Z","message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in
cases","number":200821,"url":"https://github.com/elastic/kibana/pull/200821","mergeCommit":{"message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200821","number":200821,"mergeCommit":{"message":"[ML]
Anomaly Detection anomaly charts: remove filter icons for charts
displayed in cases (#200821)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/199549\r\n\r\nThis PR hides the
filter icons for anomaly charts embeddable in cases as\r\nthey do not
have any functionality there.\r\n\r\nCases:\r\n<img width=\"947\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c\">\r\n\r\nDashboards:\r\n<img
width=\"737\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08\">\r\n\r\nexplorer:\r\n<img
width=\"1089\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170\">\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f635b32c6169af8f3866b86f62557a9b435f7e98"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
… displayed in cases (elastic#200821)

## Summary

Fixes elastic#199549

This PR hides the filter icons for anomaly charts embeddable in cases as
they do not have any functionality there.

Cases:
<img width="947" alt="image"
src="https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c">

Dashboards:
<img width="737" alt="image"
src="https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08">

explorer:
<img width="1089" alt="image"
src="https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170">

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
… displayed in cases (elastic#200821)

## Summary

Fixes elastic#199549

This PR hides the filter icons for anomaly charts embeddable in cases as
they do not have any functionality there.

Cases:
<img width="947" alt="image"
src="https://github.com/user-attachments/assets/78c7c059-f289-4dcc-97bd-8eadcd03e37c">

Dashboards:
<img width="737" alt="image"
src="https://github.com/user-attachments/assets/368c718a-62bb-4277-90d1-ad0f156a7d08">

explorer:
<img width="1089" alt="image"
src="https://github.com/user-attachments/assets/20b2bda8-a81a-4d57-b831-be6e0fb3e170">

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Filter icons in anomaly charts should not be visible in cases
5 participants