Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] - update api integration test README #200826

Merged

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Nov 19, 2024

Summary

This PR makes a small update to the README of our security_solution_api_integration folder, with the following changes:

  • point to the labeling page on our document website
  • remove some obsolete sentences
  • cleanup/improve look for the rest of the REAMDE

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team backport:version Backport to applied version labels v8.17.0 labels Nov 19, 2024
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner November 19, 2024 22:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

describe('@skipInServerless missing timestamps', () => {}); ==> tests in this suite will be excluded in Serverless

```
Test suites and cases are prefixed with specific tags (see [this docs link](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx) for more information on the tags we are using) to determine their execution in particular environments or to exclude them from specific environments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is if we are allowed to share internal links in a public repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I brought back the list of labels! Thanks for catching this!

@PhilippeOberti PhilippeOberti force-pushed the api-integrations-readme-update branch from 92c3e39 to d09c17f Compare November 27, 2024 20:01
@PhilippeOberti PhilippeOberti merged commit 6c0cf0e into elastic:main Dec 2, 2024
8 checks passed
@PhilippeOberti PhilippeOberti deleted the api-integrations-readme-update branch December 2, 2024 20:24
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17

https://github.com/elastic/kibana/actions/runs/12127357745

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
)

## Summary

This PR makes a small update to the README of our
`security_solution_api_integration` folder, with the following changes:
- point to the [labeling
page](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)
on our document website
- remove some obsolete sentences
- cleanup/improve look for the rest of the REAMDE

(cherry picked from commit 6c0cf0e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
) (#202581)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Security Solution] - update api integration test README
(#200826)](#200826)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T20:23:50Z","message":"[Security
Solution] - update api integration test README (#200826)\n\n##
Summary\r\n\r\nThis PR makes a small update to the README of
our\r\n`security_solution_api_integration` folder, with the following
changes:\r\n- point to the
[labeling\r\npage](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)\r\non
our document website\r\n- remove some obsolete sentences\r\n-
cleanup/improve look for the rest of the
REAMDE","sha":"6c0cf0efd2bf32334808f161f07d91b78fe63f67","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.17.0"],"title":"[Security
Solution] - update api integration test
README","number":200826,"url":"https://github.com/elastic/kibana/pull/200826","mergeCommit":{"message":"[Security
Solution] - update api integration test README (#200826)\n\n##
Summary\r\n\r\nThis PR makes a small update to the README of
our\r\n`security_solution_api_integration` folder, with the following
changes:\r\n- point to the
[labeling\r\npage](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)\r\non
our document website\r\n- remove some obsolete sentences\r\n-
cleanup/improve look for the rest of the
REAMDE","sha":"6c0cf0efd2bf32334808f161f07d91b78fe63f67"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200826","number":200826,"mergeCommit":{"message":"[Security
Solution] - update api integration test README (#200826)\n\n##
Summary\r\n\r\nThis PR makes a small update to the README of
our\r\n`security_solution_api_integration` folder, with the following
changes:\r\n- point to the
[labeling\r\npage](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)\r\non
our document website\r\n- remove some obsolete sentences\r\n-
cleanup/improve look for the rest of the
REAMDE","sha":"6c0cf0efd2bf32334808f161f07d91b78fe63f67"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
)

## Summary

This PR makes a small update to the README of our
`security_solution_api_integration` folder, with the following changes:
- point to the [labeling
page](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)
on our document website
- remove some obsolete sentences
- cleanup/improve look for the rest of the REAMDE
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
)

## Summary

This PR makes a small update to the README of our
`security_solution_api_integration` folder, with the following changes:
- point to the [labeling
page](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)
on our document website
- remove some obsolete sentences
- cleanup/improve look for the rest of the REAMDE
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
)

## Summary

This PR makes a small update to the README of our
`security_solution_api_integration` folder, with the following changes:
- point to the [labeling
page](https://docs.elastic.dev/security-solution/teams/analyst-experience/automation/serverless/2.labeling.mdx)
on our document website
- remove some obsolete sentences
- cleanup/improve look for the rest of the REAMDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants