Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AiOps: Change point detection - Remove unnecessary theme provider #201094

Merged

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Nov 21, 2024

Summary

Recently, an error started appearing on the Change Point Detection page:
image
This occurred because we had a duplicate Theme provider in the component tree.
After removing the duplicate:

Screen.Recording.2024-11-21.at.10.29.25.mov

@rbrtj rbrtj self-assigned this Nov 21, 2024
@rbrtj rbrtj added :ml backport:skip This commit does not require backporting v9.0.0 Team:ML Team label for ML (also use :ml) bug Fixes for quality problems that affect the customer experience labels Nov 21, 2024
@rbrtj rbrtj marked this pull request as ready for review November 21, 2024 09:47
@rbrtj rbrtj requested a review from a team as a code owner November 21, 2024 09:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj added the release_note:skip Skip the PR/issue when compiling release notes label Nov 21, 2024
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor

@rbrtj can you please check this bug it is not in the 8.16 or 8.17 brunches?

@rbrtj
Copy link
Contributor Author

rbrtj commented Nov 21, 2024

@rbrtj can you please check this bug it is not in the 8.16 or 8.17 brunches?

It is not visible on 8.16 and 8.17

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 589.6KB 589.5KB -63.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiops 16.3KB 16.2KB -70.0B

History

cc @rbrtj

@rbrtj rbrtj merged commit 51a84eb into elastic:main Nov 21, 2024
21 checks passed
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
elastic#201094)

## Summary


Recently, an error started appearing on the Change Point Detection page:

![image](https://github.com/user-attachments/assets/d802fe26-0222-4286-b32e-c967cadcd466)
This occurred because we had a duplicate Theme provider in the component
tree.
After removing the duplicate:



https://github.com/user-attachments/assets/81568e67-93dc-4c01-9db6-26c57a4c2b52

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
elastic#201094)

## Summary


Recently, an error started appearing on the Change Point Detection page:

![image](https://github.com/user-attachments/assets/d802fe26-0222-4286-b32e-c967cadcd466)
This occurred because we had a duplicate Theme provider in the component
tree.
After removing the duplicate:



https://github.com/user-attachments/assets/81568e67-93dc-4c01-9db6-26c57a4c2b52

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants