Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Use preconfigured Elser inference endpoint #201108

Closed
wants to merge 14 commits into from

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Nov 21, 2024

Closes #200908

In #186499 semantic text was added to the internal knowledge base. This uses our own inference endpoint (obs_ai_assistant_kb_inference) which must be setup before the knowledge base is available.

In 8.17 Elasticsearch ships with preconfigured elser and e5 inference endpoints (PR), meaning we don't have to have our own. This PR removes everything related to handling and validating the inference pipeline and the underlying model, since we can assume this is provided by the platform

@sorenlouv sorenlouv requested a review from sphilipse November 21, 2024 14:31
@sorenlouv sorenlouv changed the title [Obs AI Assistant] Use preconfigured endpoint [Obs AI Assistant] Use preconfigured Elser inference endpoint Nov 21, 2024
@sorenlouv sorenlouv marked this pull request as ready for review November 26, 2024 13:21
@sorenlouv sorenlouv requested review from a team as code owners November 26, 2024 13:22
@sorenlouv sorenlouv added v8.17.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix release_note:enhancement and removed release_note:fix labels Nov 26, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 26, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #7 / management Index patterns on aliases discover verify hits should be able to discover and verify no of hits for alias2
  • [job] [logs] FTR Configs #7 / management Index patterns on aliases discover verify hits should be able to discover and verify no of hits for alias2
  • [job] [logs] FTR Configs #38 / Observability AI Assistant Serverless API tests complete/complete.spec.ts /internal/observability_ai_assistant/chat/complete returns a streaming response from the server
  • [job] [logs] FTR Configs #38 / Observability AI Assistant Serverless API tests complete/complete.spec.ts /internal/observability_ai_assistant/chat/complete returns a streaming response from the server

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistantApp 379 377 -2
observabilityAiAssistantManagement 367 365 -2
searchAssistant 241 239 -2
total -6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ai-assistant 64 60 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 237.5KB 230.0KB -7.5KB
observabilityAiAssistantManagement 97.7KB 97.0KB -771.0B
searchAssistant 160.2KB 152.9KB -7.3KB
total -15.6KB
Unknown metric groups

API count

id before after diff
@kbn/ai-assistant 64 60 -4

History

@sorenlouv sorenlouv marked this pull request as draft November 27, 2024 09:22
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@sorenlouv sorenlouv closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:enhancement Team:Obs AI Assistant Observability AI Assistant v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Use preconfigured elser inference endpoint
2 participants