Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automatic Import] Correctly output icons in the manifest #201139

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Automatic Import] Correctly output icons in the manifest #201139

merged 2 commits into from
Nov 21, 2024

Conversation

ilyannn
Copy link
Contributor

@ilyannn ilyannn commented Nov 21, 2024 •
edited by kibanamachine
Loading

Release Note

Fixes a bug in Automatic Import where icons were not shown after the integration was installed.

Summary

Closes #201008 and should be backported to 8.16 and 8.15.

When implementing safe manifest output #192316 a bug crept in: the icons array was incorrectly output as a dictionary

icons:
  src: /img/logoElastic.svg
  title: syslog_test3 Logo
  size: 32x32
  type: image/svg+xml

and the test was not smart enough to pick it up:

expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.

Testing

This PR

image image

Comparison with the latest snapshot

image image

@ilyannn ilyannn added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development 8.17 candidate Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Nov 21, 2024
@ilyannn ilyannn self-assigned this Nov 21, 2024
@ilyannn ilyannn added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Nov 21, 2024
@ilyannn ilyannn marked this pull request as ready for review November 21, 2024 12:22
@ilyannn ilyannn requested a review from a team as a code owner November 21, 2024 12:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@ilyannn ilyannn merged commit 30e075a into elastic:main Nov 21, 2024
26 checks passed
@ilyannn ilyannn deleted the auto-import/fix-icons-array branch November 21, 2024 15:34
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/11956514605

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@ilyannn
[Automatic Import] Correctly output icons in the manifest (elastic#20…
781c94d 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.

(cherry picked from commit 30e075a)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@ilyannn
[Automatic Import] Correctly output icons in the manifest (elastic#20…
c2598b6 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.

(cherry picked from commit 30e075a)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@ilyannn
[Automatic Import] Correctly output icons in the manifest (elastic#20…
b5508e0 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.

(cherry picked from commit 30e075a)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 21, 2024
@ilyannn
[Automatic Import] Correctly output icons in the manifest (elastic#20…
c6561f4 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.

(cherry picked from commit 30e075a)
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @ilyannn
[8.x] [Automatic Import] Correctly output icons in the manifest (#201139
bf7e73f 
) (#201225)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import] Correctly output icons in the manifest
(#201139)](#201139)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T15:34:07Z","message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","8.17
candidate","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic
Import] Correctly output icons in the
manifest","number":201139,"url":"https://github.com/elastic/kibana/pull/201139","mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201139","number":201139,"mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}}]}] BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @ilyannn
[8.16] [Automatic Import] Correctly output icons in the manifest (#20…
bd5eb09 
…1139) (#201223)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Automatic Import] Correctly output icons in the manifest
(#201139)](#201139)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T15:34:07Z","message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","8.17
candidate","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic
Import] Correctly output icons in the
manifest","number":201139,"url":"https://github.com/elastic/kibana/pull/201139","mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201139","number":201139,"mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}}]}] BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @ilyannn
[8.17] [Automatic Import] Correctly output icons in the manifest (#20…
57e3c69 
…1139) (#201224)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Automatic Import] Correctly output icons in the manifest
(#201139)](#201139)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T15:34:07Z","message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","8.17
candidate","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic
Import] Correctly output icons in the
manifest","number":201139,"url":"https://github.com/elastic/kibana/pull/201139","mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201139","number":201139,"mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}}]}] BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 21, 2024
@kibanamachine @ilyannn
[8.15] [Automatic Import] Correctly output icons in the manifest (#20…
5454456 
…1139) (#201222)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Automatic Import] Correctly output icons in the manifest
(#201139)](#201139)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T15:34:07Z","message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","8.17
candidate","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic
Import] Correctly output icons in the
manifest","number":201139,"url":"https://github.com/elastic/kibana/pull/201139","mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201139","number":201139,"mergeCommit":{"message":"[Automatic
Import] Correctly output icons in the manifest (#201139)\n\n## Release
Note\r\n\r\nFixes a bug in Automatic Import where icons were not shown
after the\r\nintegration was installed.\r\n\r\n## Summary\r\n\r\nCloses
#201008.\r\n\r\nWhen implementing safe manifest output #192316 a bug
crept in:\r\nthe icons array was incorrectly output as a
dictionary\r\n\r\n icons:\r\n src: /img/logoElastic.svg\r\n title:
syslog_test3 Logo\r\n size: 32x32\r\n type: image/svg+xml\r\n\r\nand the
test was not smart enough to pick it up:\r\n\r\n
expect(manifest.icons).toBeTruthy();\r\n\r\nWe fix the field and add
better tests for
it.","sha":"30e075a1b601a9bd5564667b67b3112479d1eebc"}}]}] BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@ilyannn @paulinashakirova
[Automatic Import] Correctly output icons in the manifest (elastic#20…
d1dcd1c 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@ilyannn @CAWilson94
[Automatic Import] Correctly output icons in the manifest (elastic#20…
e825e07 
…1139)

## Release Note

Fixes a bug in Automatic Import where icons were not shown after the
integration was installed.

## Summary

Closes elastic#201008.

When implementing safe manifest output elastic#192316 a bug crept in:
the icons array was incorrectly output as a dictionary

    icons:
      src: /img/logoElastic.svg
      title: syslog_test3 Logo
      size: 32x32
      type: image/svg+xml

and the test was not smart enough to pick it up:

    expect(manifest.icons).toBeTruthy();

We fix the field and add better tests for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@ilyannn ilyannn

Labels
8.17 candidate backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development bug Fixes for quality problems that affect the customer experience Feature:AutomaticImport release_note:fix Team:Security-Scalability Team label for Security Integrations Scalability Team v8.15.5 v8.16.1 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Automatic Import] User-supplied SVG not included in generated package
4 participants
@ilyannn @elasticmachine @kibanamachine @bhapas