Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ML] Transforms: Improve percentiles agg validation (#197816) #201187

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[8.x] [ML] Transforms: Improve percentiles agg validation (#197816) #201187

merged 1 commit into from
Nov 21, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@rbrtj
[ML] Transforms: Improve percentiles agg validation (elastic#197816)
2bfa39d 
## Summary

Resolves elastic#138874

The Transforms percentiles aggregation now uses a ComboBox to define
percentiles.

https://github.com/user-attachments/assets/f30de65e-3555-4643-963b-821877e7b166

a few more validation cases:

https://github.com/user-attachments/assets/79339c4e-36d2-465c-bc93-c47e1f442a87

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

(cherry picked from commit 716375b)
@kibanamachine kibanamachine enabled auto-merge (squash) November 21, 2024 13:22
@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
1 task
@kibanamachine kibanamachine merged commit 596b911 into elastic:8.x Nov 21, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #67 / Entity Analytics - Entity Store @ess @skipInServerlessMKI Entity Store APIs status should return "started" when all engines are started

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
transform 487 488 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 473.5KB 475.1KB +1.6KB

cc @rbrtj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@rbrtj rbrtj

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @rbrtj