[Mappings editor] Add code improvements for source field #201188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @ElenaStoeva |
sabarasaba
approved these changes
Nov 25, 2024
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license. (cherry picked from commit 762bb7f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license. (cherry picked from commit 762bb7f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
…) (#201577) # Backport This will backport the following commits from `main` to `8.x`: - [[Mappings editor] Add code improvements for source field (#201188)](#201188) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T12:46:05Z","message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Mappings Editor","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Mappings editor] Add code improvements for source field","number":201188,"url":"https://github.com/elastic/kibana/pull/201188","mergeCommit":{"message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201188","number":201188,"mergeCommit":{"message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
) (#201576) # Backport This will backport the following commits from `main` to `8.17`: - [[Mappings editor] Add code improvements for source field (#201188)](#201188) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T12:46:05Z","message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Mappings Editor","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Mappings editor] Add code improvements for source field","number":201188,"url":"https://github.com/elastic/kibana/pull/201188","mergeCommit":{"message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201188","number":201188,"mergeCommit":{"message":"[Mappings editor] Add code improvements for source field (#201188)\n\nCloses https://github.com/elastic/kibana/issues/200769\r\n\r\n## Summary\r\n\r\nThis PR is a follow-up to https://github.com/elastic/kibana/pull/199854\r\nand it adds the following code improvements:\r\n\r\n- Replaces Mappings-editor-context-level property `hasEnterpriceLicense`\r\nwith plugin-context-level `canUseSyntheticSource` property\r\n- Adds jest tests to check if the synthetic option is correctly\r\ndisplayed based on license\r\n- Improves readability of serializer logic for the source field\r\n\r\n\r\n**How to test:**\r\nThe same test instructions from\r\nhttps://github.com//pull/199854 can be followed with a\r\nfocus on checking that the synthetic option is only available in\r\nEnterprise license.","sha":"762bb7f59d1d980aa34358c62ae0ef53e81f726e"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200769
Summary
This PR is a follow-up to #199854 and it adds the following code improvements:
hasEnterpriceLicensewith plugin-context-levelcanUseSyntheticSourcepropertyHow to test:
The same test instructions from #199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license.