Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] Update tooltip for disabled add integration button (#195552) #201337

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…95552)

## Summary

Closes elastic#191569

With the introduction of Fleet sub-feature privileges, the user needs at
least `Agent policies: all` and `Integrations: All` privileges to add
integrations. This PR updates the tooltip for when the button is
disabled accordingly.

### Steps to reproduce

1. Create a role with `None` privilege on all Fleet sub-features (or any
combination without `All` on Agent policies) and `All` on Integrations.

<img width="718" alt="Screenshot 2024-10-09 at 11 32 56"
src="https://github.com/user-attachments/assets/2ecd4473-6c4f-4366-bac9-b79d6dafb028">

2. Assign the role to a test user and log in with it.
3. Attempt to add an integration. The button should be disabled and the
tooltip should say that `Agent policies: all` and `Integrations: All`
privileges are needed.

<img width="1815" alt="Screenshot 2024-10-09 at 11 30 40"
src="https://github.com/user-attachments/assets/a322c2f9-8617-4422-8ac8-c1f881706bcd">

(cherry picked from commit d0fb004)
@kibanamachine kibanamachine enabled auto-merge (squash) November 22, 2024 10:01
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +18.0B

cc @jillguyonnet

@kibanamachine kibanamachine merged commit c5aec31 into elastic:8.x Nov 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants