Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [APM] Migrate traces tests to deployment agnostic (#200561) #201386

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes [elastic#198995](elastic#198995)
Closes elastic#198996
Part of elastic#193245

This PR contains the changes to migrate `traces` test folder to
Deployment-agnostic testing strategy.
It also adds support for deployment-agnostic snapshots validation

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 3917d02)
@kibanamachine kibanamachine enabled auto-merge (squash) November 22, 2024 13:52
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 26, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: cc8a491
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201386-cc8a49149b96

Metrics [docs]

✅ unchanged

History

cc @crespocarlos

@kibanamachine kibanamachine merged commit e127a29 into elastic:8.x Nov 26, 2024
23 checks passed
Bluefinger added a commit that referenced this pull request Dec 11, 2024
…203475)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[APM] Migrate traces tests to deployment agnostic
(#200561)](#200561)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T13:47:06Z","message":"[APM]
Migrate traces tests to deployment agnostic (#200561)\n\n##
Summary\r\n\r\nCloses
[#198995](https://github.com/elastic/kibana/issues/198995)\r\nCloses
https://github.com/elastic/kibana/issues/198996\r\nPart of
https://github.com/elastic/kibana/issues/193245\r\n\r\nThis PR contains
the changes to migrate `traces` test folder to\r\nDeployment-agnostic
testing strategy.\r\nIt also adds support for deployment-agnostic
snapshots validation\r\n\r\n### How to test\r\n\r\n-
Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\n\r\nIt's recommended to be run
against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n-
Stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```\r\n\r\n- [ ] ~(OPTIONAL, only if a test has been
unskipped) Run flaky test\r\nsuite~\r\n- [x] local run for
serverless\r\n- [x] local run for stateful\r\n- [x] MKI run for
serverless\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":200561,"url":"https://github.com/elastic/kibana/pull/200561","mergeCommit":{"message":"[APM]
Migrate traces tests to deployment agnostic (#200561)\n\n##
Summary\r\n\r\nCloses
[#198995](https://github.com/elastic/kibana/issues/198995)\r\nCloses
https://github.com/elastic/kibana/issues/198996\r\nPart of
https://github.com/elastic/kibana/issues/193245\r\n\r\nThis PR contains
the changes to migrate `traces` test folder to\r\nDeployment-agnostic
testing strategy.\r\nIt also adds support for deployment-agnostic
snapshots validation\r\n\r\n### How to test\r\n\r\n-
Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\n\r\nIt's recommended to be run
against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n-
Stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```\r\n\r\n- [ ] ~(OPTIONAL, only if a test has been
unskipped) Run flaky test\r\nsuite~\r\n- [x] local run for
serverless\r\n- [x] local run for stateful\r\n- [x] MKI run for
serverless\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200561","number":200561,"mergeCommit":{"message":"[APM]
Migrate traces tests to deployment agnostic (#200561)\n\n##
Summary\r\n\r\nCloses
[#198995](https://github.com/elastic/kibana/issues/198995)\r\nCloses
https://github.com/elastic/kibana/issues/198996\r\nPart of
https://github.com/elastic/kibana/issues/193245\r\n\r\nThis PR contains
the changes to migrate `traces` test folder to\r\nDeployment-agnostic
testing strategy.\r\nIt also adds support for deployment-agnostic
snapshots validation\r\n\r\n### How to test\r\n\r\n-
Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\n\r\nIt's recommended to be run
against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n-
Stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```\r\n\r\n- [ ] ~(OPTIONAL, only if a test has been
unskipped) Run flaky test\r\nsuite~\r\n- [x] local run for
serverless\r\n- [x] local run for stateful\r\n- [x] MKI run for
serverless\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201386","number":201386,"state":"MERGED","mergeCommit":{"sha":"e127a2902a0bb93731aa02d5825fbdeee60bdfb9","message":"[8.x]
[APM] Migrate traces tests to deployment agnostic (#200561)
(#201386)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[APM] Migrate traces tests to deployment
agnostic\n(#200561)](https://github.com/elastic/kibana/pull/200561)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-22T13:47:06Z\",\"message\":\"[APM]\nMigrate
traces tests to deployment agnostic
(#200561)\\n\\n##\nSummary\\r\\n\\r\\nCloses\n[#198995](https://github.com/elastic/kibana/issues/198995)\\r\\nCloses\nhttps://github.com/elastic/kibana/issues/198996\\r\\nPart
of\nhttps://github.com//issues/193245\\r\\n\\r\\nThis PR
contains\nthe changes to migrate `traces` test folder
to\\r\\nDeployment-agnostic\ntesting strategy.\\r\\nIt also adds support
for deployment-agnostic\nsnapshots validation\\r\\n\\r\\n### How to
test\\r\\n\\r\\n-\nServerless\\r\\n\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\nIt's
recommended to be
run\nagainst\\r\\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\\r\\n\\r\\n-\nStateful\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\n-
[ ] ~(OPTIONAL, only if a test has been\nunskipped) Run flaky
test\\r\\nsuite~\\r\\n- [x] local run for\nserverless\\r\\n- [x] local
run for stateful\\r\\n- [x] MKI run
for\nserverless\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\"],\"title\":\"[APM]\nMigrate
traces tests to
deployment\nagnostic\",\"number\":200561,\"url\":\"https://github.com/elastic/kibana/pull/200561\",\"mergeCommit\":{\"message\":\"[APM]\nMigrate
traces tests to deployment agnostic
(#200561)\\n\\n##\nSummary\\r\\n\\r\\nCloses\n[#198995](https://github.com/elastic/kibana/issues/198995)\\r\\nCloses\nhttps://github.com/elastic/kibana/issues/198996\\r\\nPart
of\nhttps://github.com//issues/193245\\r\\n\\r\\nThis PR
contains\nthe changes to migrate `traces` test folder
to\\r\\nDeployment-agnostic\ntesting strategy.\\r\\nIt also adds support
for deployment-agnostic\nsnapshots validation\\r\\n\\r\\n### How to
test\\r\\n\\r\\n-\nServerless\\r\\n\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\nIt's
recommended to be
run\nagainst\\r\\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\\r\\n\\r\\n-\nStateful\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\n-
[ ] ~(OPTIONAL, only if a test has been\nunskipped) Run flaky
test\\r\\nsuite~\\r\\n- [x] local run for\nserverless\\r\\n- [x] local
run for stateful\\r\\n- [x] MKI run
for\nserverless\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/200561\",\"number\":200561,\"mergeCommit\":{\"message\":\"[APM]\nMigrate
traces tests to deployment agnostic
(#200561)\\n\\n##\nSummary\\r\\n\\r\\nCloses\n[#198995](https://github.com/elastic/kibana/issues/198995)\\r\\nCloses\nhttps://github.com/elastic/kibana/issues/198996\\r\\nPart
of\nhttps://github.com//issues/193245\\r\\n\\r\\nThis PR
contains\nthe changes to migrate `traces` test folder
to\\r\\nDeployment-agnostic\ntesting strategy.\\r\\nIt also adds support
for deployment-agnostic\nsnapshots validation\\r\\n\\r\\n### How to
test\\r\\n\\r\\n-\nServerless\\r\\n\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\nIt's
recommended to be
run\nagainst\\r\\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\\r\\n\\r\\n-\nStateful\\r\\n```\\r\\nnode
scripts/functional_tests_server
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\\r\\nnode\nscripts/functional_test_runner
--config\nx-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\n--grep=\\\"APM\\\"\\r\\n```\\r\\n\\r\\n-
[ ] ~(OPTIONAL, only if a test has been\nunskipped) Run flaky
test\\r\\nsuite~\\r\\n- [x] local run for\nserverless\\r\\n- [x] local
run for stateful\\r\\n- [x] MKI run
for\nserverless\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"3917d02c51e9c4a83013fe83c87b77fb12bd1fbb\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Carlos Crespo <[email protected]>\nCo-authored-by:
Elastic Machine <[email protected]>"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants