[ResponseOps][Cases] Remove appMockRender from flaky tests #201406
Merged
+28
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
backport:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
force-pushed
the
fix_flaky_tests_01
branch
from
4340962
to
7f2c8b6
Compare
adcoelho
approved these changes
Nov 22, 2024
adcoelho
reviewed
Nov 22, 2024
| @@ -6,31 +6,21 @@ | |||
| */ | |||
|
|
|||
| import React from 'react'; | |||
| import { waitForEuiPopoverOpen, screen } from '@elastic/eui/lib/test/rtl'; | |||
| import { waitForEuiPopoverOpen, screen, render } from '@elastic/eui/lib/test/rtl'; | |||
There was a problem hiding this comment.
should screen and render be from '@testing-library/react' instead? Im not familiar with this eui package
There was a problem hiding this comment.
You are right! I missed that.
cnasikas
added
release_note:skip
cnasikas
force-pushed
the
fix_flaky_tests_01
branch
from
4fa342f
to
76cf636
Compare
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @cnasikas |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cnasikas
added a commit
that referenced
this pull request
Nov 25, 2024
…1406) (#201504) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Remove appMockRender from flaky tests (#201406)](#201406) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-23T10:54:29Z","message":"[ResponseOps][Cases] Remove appMockRender from flaky tests (#201406)\n\n## Summary\r\n\r\nThis PR removes the usage of `appMockRender` from some flaky tests in\r\nthe hope they will stop being flaky. We suspect that the `appMockRender`\r\nis the source of flakiness and we would like to verify our assumption.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/189105\r\nFixes: https://github.com/elastic/kibana/issues/195698\r\nFixes: https://github.com/elastic/kibana/issues/189014\r\nFixes: https://github.com/elastic/kibana/issues/176679\r\nFixes: https://github.com/elastic/kibana/issues/188951\r\nFixes: https://github.com/elastic/kibana/issues/192672\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c2c891a14072e374bd562618358dc8c027aa1ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.18.0"],"number":201406,"url":"https://github.com/elastic/kibana/pull/201406","mergeCommit":{"message":"[ResponseOps][Cases] Remove appMockRender from flaky tests (#201406)\n\n## Summary\r\n\r\nThis PR removes the usage of `appMockRender` from some flaky tests in\r\nthe hope they will stop being flaky. We suspect that the `appMockRender`\r\nis the source of flakiness and we would like to verify our assumption.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/189105\r\nFixes: https://github.com/elastic/kibana/issues/195698\r\nFixes: https://github.com/elastic/kibana/issues/189014\r\nFixes: https://github.com/elastic/kibana/issues/176679\r\nFixes: https://github.com/elastic/kibana/issues/188951\r\nFixes: https://github.com/elastic/kibana/issues/192672\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c2c891a14072e374bd562618358dc8c027aa1ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201406","number":201406,"mergeCommit":{"message":"[ResponseOps][Cases] Remove appMockRender from flaky tests (#201406)\n\n## Summary\r\n\r\nThis PR removes the usage of `appMockRender` from some flaky tests in\r\nthe hope they will stop being flaky. We suspect that the `appMockRender`\r\nis the source of flakiness and we would like to verify our assumption.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/189105\r\nFixes: https://github.com/elastic/kibana/issues/195698\r\nFixes: https://github.com/elastic/kibana/issues/189014\r\nFixes: https://github.com/elastic/kibana/issues/176679\r\nFixes: https://github.com/elastic/kibana/issues/188951\r\nFixes: https://github.com/elastic/kibana/issues/192672\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c2c891a14072e374bd562618358dc8c027aa1ea"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the usage of
appMockRenderfrom some flaky tests in the hope they will stop being flaky. We suspect that theappMockRenderis the source of flakiness and we would like to verify our assumption.Fixes: #189105
Fixes: #195698
Fixes: #189014
Fixes: #176679
Fixes: #188951
Fixes: #192672
Checklist