Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM migrations][Onboarding] Add support for topics in the onboarding page #201411

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Nov 22, 2024

Summary

part of https://github.com/elastic/security-team/issues/10667

Added support for multiple topics to the onboarding hub. Including:

  • Added group buttons to the header to select the Topic. It appears only if more than one topic is available.
  • Topics are configurable and can have required license, and capabilities, just like cards.
  • Added required experimental flags property to topic and card configurations.
  • Implemented selected topic persistence in the URL and localStorage, extending the existing feature for the selected card.
  • Siem migrations topic implemented with only connectors card (more cards will come later)
  • Connectors card shared components extracted to common/connectors

Note

This feature needs siemMigrationsEnabled experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed.

onboarding_page_topics.mov

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.18.0 labels Nov 22, 2024
@semd semd self-assigned this Nov 22, 2024
@semd semd added the backport:version Backport to applied version labels label Nov 26, 2024
@semd semd marked this pull request as ready for review November 28, 2024 16:55
@semd semd requested review from a team as code owners November 28, 2024 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@semd
Copy link
Contributor Author

semd commented Nov 28, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6277 6287 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +15.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.6KB 86.6KB +7.0B
Unknown metric groups

async chunk count

id before after diff
securitySolution 101 102 +1

ESLint disabled line counts

id before after diff
securitySolution 557 558 +1

Total ESLint disabled count

id before after diff
securitySolution 641 642 +1

History

cc @semd

Copy link
Contributor

@agusruidiazgd agusruidiazgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this changes! 😎

@semd semd enabled auto-merge (squash) November 29, 2024 10:47
@semd semd merged commit 02e9ee4 into elastic:main Nov 29, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12084815875

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 201411

Questions ?

Please refer to the Backport tool documentation

semd added a commit to semd/kibana that referenced this pull request Nov 30, 2024
…g page (elastic#201411)

## Summary

part of elastic/security-team#10667

Added support for multiple topics to the onboarding hub. Including:

- Added group buttons to the header to select the Topic. It appears only
if more than one topic is available.
- Topics are configurable and can have required license, and
capabilities, just like cards.
- Added required experimental flags property to topic and card
configurations.
- Implemented selected topic persistence in the URL and localStorage,
extending the existing feature for the selected card.
- Siem migrations topic implemented with only connectors card (more
cards will come later)
- Connectors card shared components extracted to _common/connectors_

> [!NOTE]
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work. Otherwise only the default topic will be available and the
topic selector won't be displayed.

https://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 02e9ee4)
@semd
Copy link
Contributor Author

semd commented Nov 30, 2024

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

semd added a commit that referenced this pull request Nov 30, 2024
…oarding page (#201411) (#202380)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SIEM migrations][Onboarding] Add support for topics in the
onboarding page
(#201411)](#201411)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T12:32:17Z","message":"[SIEM
migrations][Onboarding] Add support for topics in the onboarding page
(#201411)\n\n## Summary\r\n\r\npart of
https://github.com/elastic/security-team/issues/10667\r\n\r\nAdded
support for multiple topics to the onboarding hub. Including:\r\n\r\n-
Added group buttons to the header to select the Topic. It appears
only\r\nif more than one topic is available.\r\n- Topics are
configurable and can have required license, and\r\ncapabilities, just
like cards.\r\n- Added required experimental flags property to topic and
card\r\nconfigurations.\r\n- Implemented selected topic persistence in
the URL and localStorage,\r\nextending the existing feature for the
selected card.\r\n- Siem migrations topic implemented with only
connectors card (more\r\ncards will come later)\r\n- Connectors card
shared components extracted to _common/connectors_\r\n\r\n> [!NOTE]
\r\n> This feature needs `siemMigrationsEnabled` experimental flag
enabled\r\nto work. Otherwise only the default topic will be available
and the\r\ntopic selector won't be
displayed.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"02e9ee48c346bc27bd38942a8e96aea415230efe","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:version","v8.18.0"],"number":201411,"url":"https://github.com/elastic/kibana/pull/201411","mergeCommit":{"message":"[SIEM
migrations][Onboarding] Add support for topics in the onboarding page
(#201411)\n\n## Summary\r\n\r\npart of
https://github.com/elastic/security-team/issues/10667\r\n\r\nAdded
support for multiple topics to the onboarding hub. Including:\r\n\r\n-
Added group buttons to the header to select the Topic. It appears
only\r\nif more than one topic is available.\r\n- Topics are
configurable and can have required license, and\r\ncapabilities, just
like cards.\r\n- Added required experimental flags property to topic and
card\r\nconfigurations.\r\n- Implemented selected topic persistence in
the URL and localStorage,\r\nextending the existing feature for the
selected card.\r\n- Siem migrations topic implemented with only
connectors card (more\r\ncards will come later)\r\n- Connectors card
shared components extracted to _common/connectors_\r\n\r\n> [!NOTE]
\r\n> This feature needs `siemMigrationsEnabled` experimental flag
enabled\r\nto work. Otherwise only the default topic will be available
and the\r\ntopic selector won't be
displayed.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"02e9ee48c346bc27bd38942a8e96aea415230efe"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201411","number":201411,"mergeCommit":{"message":"[SIEM
migrations][Onboarding] Add support for topics in the onboarding page
(#201411)\n\n## Summary\r\n\r\npart of
https://github.com/elastic/security-team/issues/10667\r\n\r\nAdded
support for multiple topics to the onboarding hub. Including:\r\n\r\n-
Added group buttons to the header to select the Topic. It appears
only\r\nif more than one topic is available.\r\n- Topics are
configurable and can have required license, and\r\ncapabilities, just
like cards.\r\n- Added required experimental flags property to topic and
card\r\nconfigurations.\r\n- Implemented selected topic persistence in
the URL and localStorage,\r\nextending the existing feature for the
selected card.\r\n- Siem migrations topic implemented with only
connectors card (more\r\ncards will come later)\r\n- Connectors card
shared components extracted to _common/connectors_\r\n\r\n> [!NOTE]
\r\n> This feature needs `siemMigrationsEnabled` experimental flag
enabled\r\nto work. Otherwise only the default topic will be available
and the\r\ntopic selector won't be
displayed.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"02e9ee48c346bc27bd38942a8e96aea415230efe"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…g page (elastic#201411)

## Summary

part of elastic/security-team#10667

Added support for multiple topics to the onboarding hub. Including:

- Added group buttons to the header to select the Topic. It appears only
if more than one topic is available.
- Topics are configurable and can have required license, and
capabilities, just like cards.
- Added required experimental flags property to topic and card
configurations.
- Implemented selected topic persistence in the URL and localStorage,
extending the existing feature for the selected card.
- Siem migrations topic implemented with only connectors card (more
cards will come later)
- Connectors card shared components extracted to _common/connectors_

> [!NOTE]  
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work. Otherwise only the default topic will be available and the
topic selector won't be displayed.



https://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants