Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] a11y make index mappings search results accessible #201455

Merged

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Nov 22, 2024

Summary

Make index mappings search results accessible so that it can read by screen reader when navigated by keyboard

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search v8.16.0 backport:version Backport to applied version labels v8.17.0 v8.16.1 v8.16.2 labels Nov 22, 2024
@saarikabhasi saarikabhasi marked this pull request as ready for review November 22, 2024 18:16
@saarikabhasi saarikabhasi requested a review from a team as a code owner November 22, 2024 18:16
@saarikabhasi saarikabhasi enabled auto-merge (squash) December 3, 2024 16:55
@saarikabhasi saarikabhasi merged commit 5480451 into elastic:main Dec 3, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17

https://github.com/elastic/kibana/actions/runs/12146073911

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 698.1KB 698.1KB +11.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
…201455)

## Summary
Make index mappings search results accessible so that it can read by
screen reader when navigated by keyboard

(cherry picked from commit 5480451)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
…201455)

## Summary
Make index mappings search results accessible so that it can read by
screen reader when navigated by keyboard

(cherry picked from commit 5480451)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 3, 2024
…201455) (#202797)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Search] a11y make index mappings search results accessible
(#201455)](#201455)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Saarika
Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:37:51Z","message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.16.2"],"title":"[Search]
a11y make index mappings search results accessible
","number":201455,"url":"https://github.com/elastic/kibana/pull/201455","mergeCommit":{"message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201455","number":201455,"mergeCommit":{"message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Saarika Bhasi <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 3, 2024
…201455) (#202798)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Search] a11y make index mappings search results accessible
(#201455)](#201455)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Saarika
Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:37:51Z","message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0","v8.16.1","v8.16.2"],"title":"[Search]
a11y make index mappings search results accessible
","number":201455,"url":"https://github.com/elastic/kibana/pull/201455","mergeCommit":{"message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201455","number":201455,"mergeCommit":{"message":"[Search]
a11y make index mappings search results accessible (#201455)\n\n##
Summary\r\nMake index mappings search results accessible so that it can
read by\r\nscreen reader when navigated by
keyboard","sha":"5480451f27639ad923fd04c865b56c58666473fd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Saarika Bhasi <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
…201455)

## Summary
Make index mappings search results accessible so that it can read by
screen reader when navigated by keyboard
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
…201455)

## Summary
Make index mappings search results accessible so that it can read by
screen reader when navigated by keyboard
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…201455)

## Summary
Make index mappings search results accessible so that it can read by
screen reader when navigated by keyboard
@saarikabhasi saarikabhasi deleted the fix-a11y-mappings-search-results branch January 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v8.16.1 v8.16.2 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search:Indices:Index mapping page]Missing information about Search result for screen reader users
4 participants