[ILM] fix remove the unnecessary toast notification #201524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viajes7
force-pushed
the
fix/ilm_toast_error
branch
5 times, most recently
from
9b60885 to
f352650
Compare
|
Hi, @ElenaStoeva can you help review this PR? Thanks. |
viajes7
force-pushed
the
fix/ilm_toast_error
branch
from
f352650 to
191e4b5
Compare
ElenaStoeva
added
Feature:ILM
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
/ci |
|
@elasticmachine run docs-build |
ElenaStoeva
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Thanks for fixing this @viajes7! Changes lgtm, tested locally.
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
## Summary Fixes elastic#129647 After fixup: <img width="1920" alt="image" src="https://github.com/user-attachments/assets/9e423bae-63c2-4d4e-8a9f-10a922125eb8"> (cherry picked from commit 9724c46)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
…202215) # Backport This will backport the following commits from `main` to `8.x`: - [[ILM] fix remove the unnecessary toast notification (#201524)](#201524) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T16:58:57Z","message":"[ILM] fix remove the unnecessary toast notification (#201524)\n\n## Summary\r\n\r\nFixes #129647 \r\n\r\nAfter fixup:\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9e423bae-63c2-4d4e-8a9f-10a922125eb8\">","sha":"9724c46be1257a4287bb313a1cb85407bf0349e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ILM","Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"[ILM] fix remove the unnecessary toast notification","number":201524,"url":"https://github.com/elastic/kibana/pull/201524","mergeCommit":{"message":"[ILM] fix remove the unnecessary toast notification (#201524)\n\n## Summary\r\n\r\nFixes #129647 \r\n\r\nAfter fixup:\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9e423bae-63c2-4d4e-8a9f-10a922125eb8\">","sha":"9724c46be1257a4287bb313a1cb85407bf0349e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201524","number":201524,"mergeCommit":{"message":"[ILM] fix remove the unnecessary toast notification (#201524)\n\n## Summary\r\n\r\nFixes #129647 \r\n\r\nAfter fixup:\r\n\r\n<img width=\"1920\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9e423bae-63c2-4d4e-8a9f-10a922125eb8\">","sha":"9724c46be1257a4287bb313a1cb85407bf0349e3"}}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Fixes elastic#129647 After fixup: <img width="1920" alt="image" src="https://github.com/user-attachments/assets/9e423bae-63c2-4d4e-8a9f-10a922125eb8">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129647
After fixup: