[Cloud Security] Filters for Contextual Flyout Datagrid #201708

animehart · 2024-11-26T00:32:35Z

Summary

Screen.Recording.2024-11-26.at.4.52.58.PM.mov

This PR is for adding Filters for Contextual Flytout Datagrid

…ies and Misconfigurations

animehart · 2024-11-27T00:41:58Z

/ci

animehart · 2024-11-27T02:13:46Z

/ci

animehart · 2024-11-27T03:23:28Z

/ci

animehart · 2024-11-27T17:52:45Z

/ci

animehart · 2024-11-27T20:04:12Z

/ci

elasticmachine · 2024-11-27T23:16:10Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

seanrathier

Looks good, I left many comments and would be glad to discuss them if you want.

x-pack/packages/kbn-cloud-security-posture/common/utils/helpers.test.ts

seanrathier · 2024-11-28T14:41:19Z

x-pack/packages/kbn-cloud-security-posture/common/utils/helpers.ts

:opinion

We should consider renaming this file to something like queries.ts because all exported functions are related to building queries.

This is a little pet peeve of mine when directories are called utils and files helpers. I've seen this in many cases over time files like this become a kitchen sink of common functions and it becomes hard to reorganize the structure later. This will be especially hard to reorganize if other plugins start to use our shared package.

x-pack/packages/kbn-cloud-security-posture/common/queries.ts

Since this is a shared package everything is by definition common so another suggestion is to remove comment altogether

x-pack/packages/kbn-cloud-security-posture/queries.ts

wdyt?

hmmm you are right that almost all of the helpers functions here are query related and I can see the issue that this might have later in the future

I'm down to do this change but maybe in separate ticket/PR (as this PR is for Filters for the Datagrid, and this suggested change might touch other features thats not related at all with Contextual Flyout)

wdyt ?

Yes please and thank you! Can you open that issue as a tech debt?

Can you add the link to the tech debt issue here?

#202242

Lemme know if i missed anything :)

x-pack/packages/kbn-cloud-security-posture/public/src/utils/vulnerability_helpers.ts

x-pack/packages/security-solution/distribution_bar/src/distribution_bar.tsx

...ic/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx

...lic/cloud_security_posture/components/csp_details/vulnerabilities_findings_details_table.tsx

…hart/kibana into contextual-flyout-datagrid-filters

seanrathier

Almost there, just a few things to resolve. 🙏

opauloh

looks good, added some suggestions

opauloh · 2024-11-28T22:50:00Z

x-pack/packages/kbn-cloud-security-posture/common/utils/helpers.ts

@@ -43,7 +43,14 @@ export const buildMutedRulesFilter = (
  return mutedRulesFilterQuery;
 };

-export const buildEntityFlyoutPreviewQuery = (field: string, queryValue?: string) => {
+export const buildEntityFlyoutPreviewQuery = (


I guess we could create some High Order functions instead:

// Generic function export const buildGenericEntityFlyoutPreviewQuery = ( field: string, queryValue?: string, status?: string, queryField?: string ) => { return { bool: { filter: [ { bool: { should: [ { term: { [field]: `${queryValue || ''}`, }, }, ], minimum_should_match: 1, }, }, status && queryField ? { bool: { should: [ { term: { [queryField]: status, }, }, ], minimum_should_match: 1, }, } : undefined, ].filter(Boolean), }, }; }; // Higher-order function for Misconfiguration export const buildMisconfigurationEntityFlyoutPreviewQuery = ( field: string, queryValue?: string, status?: string ) => { const queryField = 'result.evaluation'; return buildGenericEntityFlyoutPreviewQuery(field, queryValue, status, queryField); }; // Higher-order function for Vulnerability export const buildVulnerabilityEntityFlyoutPreviewQuery = ( field: string, queryValue?: string, status?: string ) => { const queryField = 'vulnerability.severity'; return buildGenericEntityFlyoutPreviewQuery(field, queryValue, status, queryField); };

opauloh · 2024-11-28T22:51:06Z

x-pack/packages/kbn-cloud-security-posture/public/src/utils/vulnerability_helpers.ts

@@ -50,6 +55,14 @@ export const getVulnerabilityStats = (
      ),
      count: counts.none,
      color: getSeverityStatusColor(VULNERABILITIES_SEVERITY.UNKNOWN),
+      filter: () => {
+        filterFunction?.('UNKNOWN');


let's update to use the constant:

filterFunction?.(VULNERABILITIES_SEVERITY.UNKNOWN);

opauloh · 2024-11-28T22:58:08Z

...ic/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx

@@ -41,6 +47,14 @@ const getFindingsStats = (passedFindingsStats: number, failedFindingsStats: numb
      ),
      count: passedFindingsStats,
      color: euiThemeVars.euiColorSuccess,
+      filter: () => {
+        filterFunction('passed');


can we add 'passed' and 'failed' values to a constant?

janmonschke

THI changes lgtm

elasticmachine · 2024-12-02T17:21:47Z

💚 Build Succeeded

Buildkite Build
Commit: def34d8

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/cloud-security-posture`	89	93	+4
`@kbn/cloud-security-posture-common`	107	120	+13
total			+17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	14.6MB	14.6MB	+2.0KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/cloud-security-posture`	89	93	+4
`@kbn/cloud-security-posture-common`	109	122	+13
total			+17

History

💛 Build #255445 was flaky 823c3b4
💚 Build #255186 succeeded ab8dace
💔 Build #255141 failed f61c6ba
💔 Build #255104 failed 95ba1bd
💔 Build #254750 failed cb51053
💔 Build #254734 failed 0f7efea

kibanamachine · 2024-12-02T17:26:19Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12124654067

## Summary https://github.com/user-attachments/assets/59ace35f-62b8-4c08-bf2c-eed200db791d This PR is for adding Filters for Contextual Flytout Datagrid (cherry picked from commit 2f62cde)

kibanamachine · 2024-12-02T17:31:10Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

… (#202556) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Filters for Contextual Flyout Datagrid (#201708)](#201708)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Rickyanto Ang <[email protected]>

## Summary https://github.com/user-attachments/assets/59ace35f-62b8-4c08-bf2c-eed200db791d This PR is for adding Filters for Contextual Flytout Datagrid

animehart added 2 commits November 25, 2024 16:27

initial push - added filters functionality and state for Vulnerabilit…

ddd0636

…ies and Misconfigurations

added filter for Alerts

0f7efea

added new jest, clean up

cb51053

updated jest

95ba1bd

Merge branch 'main' into contextual-flyout-datagrid-filters

f61c6ba

animehart marked this pull request as ready for review November 27, 2024 23:15

animehart requested a review from a team as a code owner November 27, 2024 23:15

animehart added v8.18.0 v9.0.0 Team:Cloud Security Cloud Security team related labels Nov 27, 2024

animehart added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 27, 2024

Merge branch 'main' into contextual-flyout-datagrid-filters

ab8dace

animehart requested a review from opauloh November 27, 2024 23:39

seanrathier reviewed Nov 28, 2024

View reviewed changes

animehart added 3 commits November 28, 2024 10:58

pr comments

50c058a

Merge branch 'contextual-flyout-datagrid-filters' of github.com:anime…

7d3efa9

…hart/kibana into contextual-flyout-datagrid-filters

forgot to add these 2

823c3b4

animehart requested a review from seanrathier November 28, 2024 20:33

seanrathier reviewed Nov 28, 2024

View reviewed changes

animehart mentioned this pull request Nov 28, 2024

Renaming and Moving helper functions and its folder on CSP Package #202242

Open

seanrathier approved these changes Nov 28, 2024

View reviewed changes

opauloh approved these changes Nov 28, 2024

View reviewed changes

added status as constants

395d839

more pr comments

ccf30c5

animehart requested a review from a team as a code owner November 29, 2024 01:54

janmonschke approved these changes Dec 2, 2024

View reviewed changes

Merge branch 'main' into contextual-flyout-datagrid-filters

def34d8

animehart merged commit 2f62cde into elastic:main Dec 2, 2024
8 checks passed

kibanamachine mentioned this pull request Dec 2, 2024

[8.x] [Cloud Security] Filters for Contextual Flyout Datagrid (#201708) #202556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cloud Security] Filters for Contextual Flyout Datagrid #201708

[Cloud Security] Filters for Contextual Flyout Datagrid #201708

animehart commented Nov 26, 2024 •

edited by kibanamachine

Loading

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

elasticmachine commented Nov 27, 2024

seanrathier left a comment

seanrathier Nov 28, 2024

animehart Nov 28, 2024

seanrathier Nov 28, 2024

seanrathier Nov 28, 2024

animehart Nov 28, 2024

seanrathier left a comment

opauloh left a comment

opauloh Nov 28, 2024

opauloh Nov 28, 2024

animehart Nov 28, 2024

opauloh Nov 28, 2024

janmonschke left a comment

elasticmachine commented Dec 2, 2024

API count

kibanamachine commented Dec 2, 2024

kibanamachine commented Dec 2, 2024

[Cloud Security] Filters for Contextual Flyout Datagrid #201708

[Cloud Security] Filters for Contextual Flyout Datagrid #201708

Conversation

animehart commented Nov 26, 2024 • edited by kibanamachine Loading

Summary

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

animehart commented Nov 27, 2024

elasticmachine commented Nov 27, 2024

seanrathier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanrathier left a comment

Choose a reason for hiding this comment

opauloh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janmonschke left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 2, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

kibanamachine commented Dec 2, 2024

kibanamachine commented Dec 2, 2024

💚 All backports created successfully

Questions ?

animehart commented Nov 26, 2024 •

edited by kibanamachine

Loading