[Lens][Embeddable] Fix rendering time API #201730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
added
the
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Async chunks
|
markov00
reviewed
Nov 28, 2024
x-pack/plugins/lens/public/react_embeddable/renderer/lens_embeddable_component.tsx
Show resolved
Hide resolved
markov00
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
I've checked the triggering of the dashboard_loaded and within this PR it get triggered exactly when the chart is rendered as it should be.
On main instead it was triggered before that.
On my test the difference is now pretty visible: from 2s to 3s for the same chart/dashboard.
It was too good to last...
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
## Summary This PR implements the new Embeddable API to signalling the render complete event here: elastic#200640 The previous API was relying on the `dataLoading` API which could report the wrong timing as rendering could take a bit more time, but with the new one (bound to the internal` renderingComplete$`) it should be correct now. (cherry picked from commit 43aa838)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix rendering time API (#201730)](#201730) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T15:22:57Z","message":"[Lens][Embeddable] Fix rendering time API (#201730)\n\n## Summary\r\n\r\nThis PR implements the new Embeddable API to signalling the render\r\ncomplete event here: https://github.com/elastic/kibana/pull/200640\r\n\r\nThe previous API was relying on the `dataLoading` API which could report\r\nthe wrong timing as rendering could take a bit more time, but with the\r\nnew one (bound to the internal` renderingComplete# Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix rendering time API (#201730)](#201730) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT ) it should be\r\ncorrect now.","sha":"43aa838c042af3375485ab57a26e975c68adcf09","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens][Embeddable] Fix rendering time API","number":201730,"url":"https://github.com/elastic/kibana/pull/201730","mergeCommit":{"message":"[Lens][Embeddable] Fix rendering time API (#201730)\n\n## Summary\r\n\r\nThis PR implements the new Embeddable API to signalling the render\r\ncomplete event here: https://github.com/elastic/kibana/pull/200640\r\n\r\nThe previous API was relying on the `dataLoading` API which could report\r\nthe wrong timing as rendering could take a bit more time, but with the\r\nnew one (bound to the internal` renderingComplete# Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix rendering time API (#201730)](#201730) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT ) it should be\r\ncorrect now.","sha":"43aa838c042af3375485ab57a26e975c68adcf09"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201730","number":201730,"mergeCommit":{"message":"[Lens][Embeddable] Fix rendering time API (#201730)\n\n## Summary\r\n\r\nThis PR implements the new Embeddable API to signalling the render\r\ncomplete event here: https://github.com/elastic/kibana/pull/200640\r\n\r\nThe previous API was relying on the `dataLoading` API which could report\r\nthe wrong timing as rendering could take a bit more time, but with the\r\nnew one (bound to the internal` renderingComplete# Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix rendering time API (#201730)](#201730) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT ) it should be\r\ncorrect now.","sha":"43aa838c042af3375485ab57a26e975c68adcf09"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary This PR implements the new Embeddable API to signalling the render complete event here: elastic#200640 The previous API was relying on the `dataLoading` API which could report the wrong timing as rendering could take a bit more time, but with the new one (bound to the internal` renderingComplete$`) it should be correct now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the new Embeddable API to signalling the render complete event here: #200640
The previous API was relying on the
dataLoadingAPI which could report the wrong timing as rendering could take a bit more time, but with the new one (bound to the internalrenderingComplete$) it should be correct now.