Sustainable Kibana Architecture: Temporarily allow non-snake case package names #201736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
delanni
approved these changes
Nov 26, 2024
gsoldevila
force-pushed
the
kbn-team-1309-relax-snake-casing-rule
branch
from
4bb93d5 to
39bc24e
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…kage names (elastic#201736) ## Summary In the context of _Sustainable Kibana Architecture_, we want to relocate plugins and packages to dedicated solutions folders. Current CI checks enforce snake case for new package names, and we cannot afford the extra churn of renaming all packages' folders during relocation. The PR aims at relaxing this constraint, only for the target folders of the relocation.
gsoldevila
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 9, 2024
…kage names (elastic#201736) ## Summary In the context of _Sustainable Kibana Architecture_, we want to relocate plugins and packages to dedicated solutions folders. Current CI checks enforce snake case for new package names, and we cannot afford the extra churn of renaming all packages' folders during relocation. The PR aims at relaxing this constraint, only for the target folders of the relocation. (cherry picked from commit 2850f68)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 9, 2024
…kage names (elastic#201736) ## Summary In the context of _Sustainable Kibana Architecture_, we want to relocate plugins and packages to dedicated solutions folders. Current CI checks enforce snake case for new package names, and we cannot afford the extra churn of renaming all packages' folders during relocation. The PR aims at relaxing this constraint, only for the target folders of the relocation. (cherry picked from commit 2850f68)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
…se package names (#201736) (#203404) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Temporarily allow non-snake case package names (#201736)](#201736) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T12:58:18Z","message":"Sustainable Kibana Architecture: Temporarily allow non-snake case package names (#201736)\n\n## Summary\r\n\r\nIn the context of _Sustainable Kibana Architecture_, we want to relocate\r\nplugins and packages to dedicated solutions folders.\r\nCurrent CI checks enforce snake case for new package names, and we\r\ncannot afford the extra churn of renaming all packages' folders during\r\nrelocation.\r\n\r\nThe PR aims at relaxing this constraint, only for the target folders of\r\nthe relocation.","sha":"2850f68406960592b71a8e8ee21b1a8831f7348b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Sustainable Kibana Architecture: Temporarily allow non-snake case package names","number":201736,"url":"https://github.com/elastic/kibana/pull/201736","mergeCommit":{"message":"Sustainable Kibana Architecture: Temporarily allow non-snake case package names (#201736)\n\n## Summary\r\n\r\nIn the context of _Sustainable Kibana Architecture_, we want to relocate\r\nplugins and packages to dedicated solutions folders.\r\nCurrent CI checks enforce snake case for new package names, and we\r\ncannot afford the extra churn of renaming all packages' folders during\r\nrelocation.\r\n\r\nThe PR aims at relaxing this constraint, only for the target folders of\r\nthe relocation.","sha":"2850f68406960592b71a8e8ee21b1a8831f7348b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201736","number":201736,"mergeCommit":{"message":"Sustainable Kibana Architecture: Temporarily allow non-snake case package names (#201736)\n\n## Summary\r\n\r\nIn the context of _Sustainable Kibana Architecture_, we want to relocate\r\nplugins and packages to dedicated solutions folders.\r\nCurrent CI checks enforce snake case for new package names, and we\r\ncannot afford the extra churn of renaming all packages' folders during\r\nrelocation.\r\n\r\nThe PR aims at relaxing this constraint, only for the target folders of\r\nthe relocation.","sha":"2850f68406960592b71a8e8ee21b1a8831f7348b"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…kage names (elastic#201736) ## Summary In the context of _Sustainable Kibana Architecture_, we want to relocate plugins and packages to dedicated solutions folders. Current CI checks enforce snake case for new package names, and we cannot afford the extra churn of renaming all packages' folders during relocation. The PR aims at relaxing this constraint, only for the target folders of the relocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the context of Sustainable Kibana Architecture, we want to relocate plugins and packages to dedicated solutions folders.
Current CI checks enforce snake case for new package names, and we cannot afford the extra churn of renaming all packages' folders during relocation.
The PR aims at relaxing this constraint, only for the target folders of the relocation.