[Stateful sidenav] Fix highlight colours #201823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
release_note:skip
|
/ci |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
commented
Nov 27, 2024
| @@ -43,7 +43,9 @@ jest.mock('@testing-library/react', () => { | |||
| const originalConsoleError = console.error; | |||
| console.error = (...args) => { | |||
| if (global.IS_REACT_ACT_ENVIRONMENT === false) { | |||
| if (args[0].includes('Warning: An update to %s inside a test was not wrapped in act')) { | |||
| if ( | |||
| args[0].toString().includes('Warning: An update to %s inside a test was not wrapped in act') | |||
There was a problem hiding this comment.
I had to convert to String as the error that was passed was an "object" type that does not have the includes prop
jbudz
approved these changes
Nov 27, 2024
Dosant
approved these changes
Nov 27, 2024
sebelga
commented
Nov 27, 2024
| a { | ||
| text-decoration: auto; | ||
| } | ||
| export const SolutionSideNavPanelItemStyles = (euiTheme: EuiThemeComputed<{}>) => css` |
There was a problem hiding this comment.
Had to move those style outside as for the platform side nav the links are rendered in a different panel
semd
reviewed
Nov 27, 2024
x-pack/packages/security-solution/side_nav/src/solution_side_nav_panel.tsx
Outdated
Show resolved
Hide resolved
semd
approved these changes
Nov 27, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @sebelga |
pheyos
approved these changes
Nov 28, 2024
kdelemme
approved these changes
Nov 28, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
(cherry picked from commit d0794de)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Fix highlight colours (#201823)](#201823) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T21:38:19Z","message":"[Stateful sidenav] Fix highlight colours (#201823)","sha":"d0794de945777d829f32582cf1459679faabf3b3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Chrome","ci:project-deploy-observability"],"title":"[Stateful sidenav] Fix highlight colours","number":201823,"url":"https://github.com/elastic/kibana/pull/201823","mergeCommit":{"message":"[Stateful sidenav] Fix highlight colours (#201823)","sha":"d0794de945777d829f32582cf1459679faabf3b3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201823","number":201823,"mergeCommit":{"message":"[Stateful sidenav] Fix highlight colours (#201823)","sha":"d0794de945777d829f32582cf1459679faabf3b3"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've fixed some highlights problem in the new solution sidenav (see linked issue).
Screenshots
Fixes #197749
Fixes #200219