Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slo): Access Cases from SLO details page #201834

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix(slo): Access Cases from SLO details page #201834

merged 4 commits into from
Nov 27, 2024

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Nov 26, 2024 •
edited by kibanamachine
Loading

Resolves #198564

🐈 Summary

This PR fixes the missing plugin dependency for opening Cases from the Alerts tab under SLO Details page.
I've decided to add it as an optional dependency to avoid blocking the SLO plugin in case it was not enable, since this is used only for that particular feature.

🧬 Testing

  1. Create an SLO with high objective, let the alerts fire.
  2. Go to the Alerts tab under the SLO Details page
  3. Click on the active alert > Add to existing case or Add to new case
  4. Assert no error is shown and flyout/popover loads correctly

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Nov 26, 2024
@kdelemme kdelemme self-assigned this Nov 26, 2024
@kdelemme kdelemme marked this pull request as ready for review November 26, 2024 16:45
@kdelemme kdelemme requested review from a team as code owners November 26, 2024 16:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

afharo
afharo approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 26, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: d22bca1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201834-d22bca1b26de

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #61 / serverless security UI Serverless Security Cases Cases List bulk actions status change the status of cases to in-progress correctly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
slo 45 47 +2
Unknown metric groups

API count

id before after diff
slo 45 47 +2

History

cc @kdelemme

dominiqueclarke
dominiqueclarke approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 6fc08a3 into elastic:main Nov 27, 2024
27 checks passed
@kdelemme kdelemme deleted the fix/cases-slo-details-page branch November 27, 2024 12:41
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12050518075

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] App plugin (#200060)

Manual backport

To create the backport manually run:

node scripts/backport --pr 201834

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 28, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 201834 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 201834 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 201834 locally

@kdelemme kdelemme mentioned this pull request Dec 2, 2024
Merged
@kdelemme
Copy link
Contributor Author

kdelemme commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit to kdelemme/kibana that referenced this pull request Dec 2, 2024
@kdelemme
fix(slo): Access Cases from SLO details page (elastic#201834)
80d3c17 
(cherry picked from commit 6fc08a3)

# Conflicts:
#	x-pack/plugins/observability_solution/slo/tsconfig.json
@kibanamachine kibanamachine mentioned this pull request Dec 3, 2024
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kdelemme added a commit that referenced this pull request Dec 3, 2024
@kdelemme @kibanamachine
[8.x] fix(slo): Access Cases from SLO details page (#201834) (#202485)
0e1734d 
# Backport

This will backport the following commits from `main` to `8.x`:
- [fix(slo): Access Cases from SLO details page
(#201834)](#201834)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T12:41:52Z","message":"fix(slo):
Access Cases from SLO details page
(#201834)","sha":"6fc08a30d452a06e9d9b51341e95026a02588e95","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.18.0"],"number":201834,"url":"https://github.com/elastic/kibana/pull/201834","mergeCommit":{"message":"fix(slo):
Access Cases from SLO details page
(#201834)","sha":"6fc08a30d452a06e9d9b51341e95026a02588e95"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201834","number":201834,"mergeCommit":{"message":"fix(slo):
Access Cases from SLO details page
(#201834)","sha":"6fc08a30d452a06e9d9b51341e95026a02588e95"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 3, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@kdelemme @CAWilson94
fix(slo): Access Cases from SLO details page (elastic#201834)
099fe5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@afharo afharo afharo approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Fix add to new/existing case action in the SLO alerts table
5 participants
@kdelemme @elasticmachine @kibanamachine @afharo @dominiqueclarke