Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix deprecated usage of license plugin #201964

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[APM] Fix deprecated usage of license plugin #201964

merged 1 commit into from
Nov 28, 2024
+6 −5

Conversation

miloszmarcinkowski
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski commented Nov 27, 2024 •
edited by kibanamachine
Loading

Closes #200709

Summary

This PR replaces deprecated usage of licensing plugin (remove plugin from setup in favor of start up).

@miloszmarcinkowski miloszmarcinkowski added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 27, 2024
@miloszmarcinkowski miloszmarcinkowski force-pushed the 200709-apm-fix-deprecated-usage-of-license branch from 064cf3b to 895efb2 Compare November 27, 2024 12:25
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +8.0B
Unknown metric groups

References to deprecated APIs

id before after diff
apm 33 32 -1

@miloszmarcinkowski miloszmarcinkowski marked this pull request as ready for review November 27, 2024 14:30
@miloszmarcinkowski miloszmarcinkowski requested a review from a team as a code owner November 27, 2024 14:30
@kpatticha
Copy link
Contributor

@miloszmarcinkowski

remove plugin from setup in favor of start up

Could you provide more details about the rationale for removing the plugin from the setup phase to the startup phase?

@miloszmarcinkowski
Copy link
Contributor Author

miloszmarcinkowski commented Nov 28, 2024 •
edited
Loading

@miloszmarcinkowski

remove plugin from setup in favor of start up

Could you provide more details about the rationale for removing the plugin from the setup phase to the startup phase?

@kpatticha
I don't know a specific reasoning, but this is the recommendation from deprecation note. I tested changes manually, and I didn't notice anything wrong after switching to start phase.

kibana/x-pack/plugins/licensing/public/types.ts

Lines 20 to 25 in 3e899e7

license$: Observable<ILicense>;
/**
* Triggers licensing information re-fetch.
* @deprecated in favour of the counterpart provided from start contract
* @removeBy 8.8.0
*/

jennypavlova
jennypavlova approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (Code review only)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kpatticha
kpatticha approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@miloszmarcinkowski miloszmarcinkowski merged commit 0b77cbe into elastic:main Nov 28, 2024
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12071298202

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
@miloszmarcinkowski
[APM] Fix deprecated usage of license plugin (elastic#201964)
1a02519 
Closes elastic#200709

## Summary

This PR replaces deprecated usage of licensing plugin (remove plugin
from setup in favor of start up).

(cherry picked from commit 0b77cbe)
@kibanamachine kibanamachine mentioned this pull request Nov 28, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2024
@kibanamachine @miloszmarcinkowski
[8.x] [APM] Fix deprecated usage of license plugin (#201964) (#202189)
3fa1289 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Fix deprecated usage of license plugin
(#201964)](#201964)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milosz
Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T15:00:15Z","message":"[APM]
Fix deprecated usage of license plugin (#201964)\n\nCloses
#200709\r\n\r\n## Summary\r\n\r\nThis PR replaces deprecated usage of
licensing plugin (remove plugin\r\nfrom setup in favor of start
up).","sha":"0b77cbe3d9143932b7e80fe46e0f3ddecf0f6389","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
Fix deprecated usage of license
plugin","number":201964,"url":"https://github.com/elastic/kibana/pull/201964","mergeCommit":{"message":"[APM]
Fix deprecated usage of license plugin (#201964)\n\nCloses
#200709\r\n\r\n## Summary\r\n\r\nThis PR replaces deprecated usage of
licensing plugin (remove plugin\r\nfrom setup in favor of start
up).","sha":"0b77cbe3d9143932b7e80fe46e0f3ddecf0f6389"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201964","number":201964,"mergeCommit":{"message":"[APM]
Fix deprecated usage of license plugin (#201964)\n\nCloses
#200709\r\n\r\n## Summary\r\n\r\nThis PR replaces deprecated usage of
licensing plugin (remove plugin\r\nfrom setup in favor of start
up).","sha":"0b77cbe3d9143932b7e80fe46e0f3ddecf0f6389"}}]}] BACKPORT-->

Co-authored-by: Milosz Marcinkowski <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@miloszmarcinkowski @CAWilson94
[APM] Fix deprecated usage of license plugin (elastic#201964)
fc5d4c9 
Closes elastic#200709

## Summary

This PR replaces deprecated usage of licensing plugin (remove plugin
from setup in favor of start up).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@kpatticha kpatticha kpatticha approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Fix deprecated usage of license$
5 participants
@miloszmarcinkowski @elasticmachine @kpatticha @kibanamachine @jennypavlova