[8.17] [Security Solution][Expandable flyout] - remove unused code (#201477) #202047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…201477) ## Summary Some code was added in [this PR](elastic#189633) to allow the expandable flyout to be used in the OneDiscover context. Later on, [this PR](elastic#198294) reverted most of the changes, but some files remained. This PR cleans up all the files (that I could find) that are now unnecessary and unused (cherry picked from commit 7ebd150)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Public APIs missing exports
|
PhilippeOberti
added a commit
that referenced
this pull request
Dec 13, 2024
…01477) (#204153) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Expandable flyout] - remove unused code (#201477)](#201477) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T17:59:01Z","message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.17.0"],"number":201477,"url":"https://github.com/elastic/kibana/pull/201477","mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201477","number":201477,"mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/202047","number":202047,"state":"MERGED","mergeCommit":{"sha":"a4b919479a733a6a97b2b35b49f99bed5589f3fa","message":"[8.17] [Security Solution][Expandable flyout] - remove unused code (#201477) (#202047)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[Security Solution][Expandable flyout] - remove unused code\n(#201477)](https://github.com/elastic/kibana/pull/201477)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Philippe\nOberti\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-27T17:59:01Z\",\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting:Investigations\",\"backport:version\",\"v8.17.0\"],\"title\":\"[Security\nSolution][Expandable flyout] - remove unused\ncode\",\"number\":201477,\"url\":\"https://github.com/elastic/kibana/pull/201477\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201477\",\"number\":201477,\"mergeCommit\":{\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\"}},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Philippe Oberti <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation