Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] [UA] Update wizard copy to callout "x.last" (#201633) #202159

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 28, 2024

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

Screenshot

Screenshot 2024-11-28 at 12 41 48

## Summary

We want to make sure users for the upgrade assistant are aware that the
only way to safely perform a major version upgrade is to upgrade to the
latest minor of the major they are on.

### Current
<img width="1258" alt="Screenshot 2024-11-25 at 16 44 37"
src="https://github.com/user-attachments/assets/ad114e44-82f4-4afd-98b4-0fe307c8175b">

### Next

<img width="1265" alt="Screenshot 2024-11-27 at 13 52 30"
src="https://github.com/user-attachments/assets/b02b54a0-cb9e-439e-9218-f1ebe813c1fa">

Related elastic#201377

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

(cherry picked from commit e3c532b)

# Conflicts:
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
#	x-pack/plugins/upgrade_assistant/public/application/components/overview/overview.tsx
@jloleysens jloleysens merged commit a341042 into elastic:7.17 Nov 28, 2024
87 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 186.9KB 187.2KB +241.0B

@jloleysens jloleysens deleted the backport/7.17/pr-201633 branch November 28, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants