[8.x] [Vega] Improve contrast ratio for vega visualizations tooltip key text (#200208) #202192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#200208) ## Summary Closes elastic#151923 We need to improve the contrast ratio in vega kibana tooltip key text. The current contrast ratio between the background (#404040) and the text color (#98A2B3) is below 4.5:1 and fails WCAG SC 1.4.3 Contrast (Minimum). In order to solve this issue, we have updated the color used for the **key value** the to use `colors.lightShade` (#D3DAE6). With this change, we have increased the contrast ratio from 4.02 to 7.37. You can see the available shades [here](https://eui.elastic.co/#/theming/colors/values#shades). ### Screenshots #### Before - contrast ratio 4.02  #### After - contrast ratio 7.37  ### Checklist Check the PR satisfies following conditions. - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 2b1f12b)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation