Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance lens group4 config #202260

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Balance lens group4 config #202260

merged 4 commits into from
Nov 29, 2024

Conversation

fake-haris
Copy link
Contributor

@fake-haris fake-haris commented Nov 29, 2024 •
edited
Loading

#276

Summary

The following "Functional Tests" config has duration that exceed the maximum amount of time desired for a single CI job.

  • x-pack/test/functional/apps/lens/group4/config.ts: 60 minutes

After split, every config has duration around 30 minutes.

  • x-pack/test/functional/apps/lens/group4/config.ts: 20 minutes
  • x-pack/test/functional/apps/lens/group7/config.ts: 30 minutes

@fake-haris fake-haris requested review from a team as code owners November 29, 2024 08:42
@fake-haris fake-haris self-assigned this Nov 29, 2024
@fake-haris fake-haris added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Nov 29, 2024
@markov00 markov00 self-requested a review November 29, 2024 09:01
@markov00
Copy link
Member

duplicate of #200007

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 29, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @fake-haris

@dej611
Copy link
Contributor

dej611 commented Nov 29, 2024

I saw the tsdb suite here has been kept into group4.
I'll update my PR to fit the same timings. I've added few more tweaks there to speed up the execution: #200007

@dmlemeshko
Copy link
Member

dmlemeshko commented Nov 29, 2024 •
edited
Loading

You need to update loading test files in original group4 directory:

https://github.com/fake-haris/kibana/blob/eb9464bbe4212f85e96deef21c9513f1b0c095ff/x-pack/test/functional/apps/lens/group4/index.ts#L85

It no longer exists in the directory, just remove it

dmlemeshko
dmlemeshko requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just need to remove test file loading in original index file

@fake-haris
Copy link
Contributor Author

@elasticmachine merge upstream

@fake-haris fake-haris merged commit c1b247e into elastic:main Nov 29, 2024
8 checks passed
@jbudz jbudz mentioned this pull request Jan 9, 2025
Merged
jbudz added a commit that referenced this pull request Jan 10, 2025
@jbudz @fake-haris
[8.x] Balance lens group4 config (#202260) (#205985)
69c421c 
Backports #202260

8.x is going to be around for a while, so we want to backport group
balancing when applicable.

Co-authored-by: Charis Kalpakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@delanni delanni delanni approved these changes

@pheyos pheyos pheyos approved these changes

@markov00 markov00 Awaiting requested review from markov00

Assignees

@fake-haris fake-haris

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fake-haris @markov00 @elasticmachine @dej611 @dmlemeshko @pheyos @delanni @kibanamachine