Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Manual migration from access tags to authz #202486

Conversation

viduni94
Copy link
Contributor

@viduni94 viduni94 commented Dec 2, 2024

Summary

Problem

tags: [access:ai_assistant] is deprecated.

Solution

All the routes that use this tag needs to be migrated to the authz: requiredPrivileges property.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Dec 2, 2024
@viduni94 viduni94 self-assigned this Dec 2, 2024
@viduni94 viduni94 requested a review from a team as a code owner December 2, 2024 14:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 2, 2024
@viduni94 viduni94 force-pushed the manual-migration-for-routes-with-access-tag branch from b88f800 to a5a5a25 Compare December 2, 2024 14:30
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we need a generic auth test that verifies the privilege of routes?

@viduni94
Copy link
Contributor Author

viduni94 commented Dec 2, 2024

lgtm. Do we need a generic auth test that verifies the privilege of routes?

Thanks @sorenlouv
Do you mean a test like this for each endpoint?

@viduni94 viduni94 changed the title [Obs AI Assistant] Manual migration from access tags to authz for obs… [Obs AI Assistant] Manual migration from access tags to authz Dec 2, 2024
@sorenlouv
Copy link
Member

Thanks @sorenlouv Do you mean a test like this for each endpoint?

As discussed offline, yes that would be nice. Just something super simple.

@viduni94 viduni94 force-pushed the manual-migration-for-routes-with-access-tag branch from a5a5a25 to 587dcb7 Compare December 3, 2024 13:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 587dcb7
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202486-587dcb75f98a

Metrics [docs]

✅ unchanged

History

cc @viduni94

@viduni94
Copy link
Contributor Author

viduni94 commented Dec 3, 2024

The latest changes I pushed are not being reflected in this PR, closing this and re-opening a new PR

@viduni94 viduni94 closed this Dec 3, 2024
@viduni94
Copy link
Contributor Author

viduni94 commented Dec 3, 2024

New PR - #202817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants