[ECO][Inventory v2] APM changes #202497
Merged
[ECO][Inventory v2] APM changes #202497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
rmyz
approved these changes
Dec 16, 2024
x-pack/plugins/observability_solution/apm/server/routes/entities/services/routes.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/server/routes/services/route.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
History
|
iblancof
approved these changes
Dec 17, 2024
|
|
||
| interface Params { | ||
| entitiesESClient: EntitiesESClient; | ||
| entityManagerClient: EntityClient; |
There was a problem hiding this comment.
Why not keep the name as entityClient to match the type EntityClient?
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
Closes [202299](elastic#202299) ## Summary This PR replaces the query in `getServiceEntitySummary` with the v2 function (`entityManagerClient.v2.searchEntities`) ## Testing - Verify the response of the summary endpoint in the UI: https://github.com/user-attachments/assets/ba895f7d-57c8-492b-81dd-cf7869ffbc86 - Dev tools query - APM service #### Request: ``` GET kbn:/internal/apm/entities/services/synth-node-0/summary?environment=ENVIRONMENT_ALL ``` #### Response ``` { "serviceName": "synth-node-0", "agentName": "nodejs", "lastSeenTimestamp": "2024-12-13T16:29:19.868Z", "dataStreamTypes": [ "logs", "traces" ], "environments": [ "Synthtrace: simple_trace" ] } ``` - Service from logs #### Request: ``` GET kbn:/internal/apm/entities/services/synth-node/summary?environment=ENVIRONMENT_ALL ``` #### Response: ``` { "serviceName": "synth-node", "agentName": "go", "lastSeenTimestamp": "2024-12-13T16:27:43.461Z", "dataStreamTypes": [ "logs", "traces" ], "environments": [ "Synthtrace: logs_traces_hosts" ] } ``` --------- Co-authored-by: Jenny <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a66c139)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ECO][Inventory v2] APM changes (#202497)](#202497) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T09:24:33Z","message":"[ECO][Inventory v2] APM changes (#202497)\n\nCloses [202299](https://github.com/elastic/kibana/issues/202299)\r\n\r\n## Summary\r\n\r\nThis PR replaces the query in `getServiceEntitySummary` with the v2\r\nfunction (`entityManagerClient.v2.searchEntities`)\r\n\r\n## Testing\r\n- Verify the response of the summary endpoint in the UI:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ba895f7d-57c8-492b-81dd-cf7869ffbc86\r\n\r\n\r\n\r\n- Dev tools query\r\n - APM service\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node-0/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response\r\n ```\r\n {\r\n \"serviceName\": \"synth-node-0\",\r\n \"agentName\": \"nodejs\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:29:19.868Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: simple_trace\"\r\n ]\r\n }\r\n ```\r\n\r\n - Service from logs\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response: \r\n ```\r\n {\r\n \"serviceName\": \"synth-node\",\r\n \"agentName\": \"go\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:27:43.461Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: logs_traces_hosts\"\r\n ]\r\n }\r\n ```\r\n\r\n---------\r\n\r\nCo-authored-by: Jenny <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a66c1399e60b184c338fc99c9550539bd2ecf68b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[ECO][Inventory v2] APM changes","number":202497,"url":"https://github.com/elastic/kibana/pull/202497","mergeCommit":{"message":"[ECO][Inventory v2] APM changes (#202497)\n\nCloses [202299](https://github.com/elastic/kibana/issues/202299)\r\n\r\n## Summary\r\n\r\nThis PR replaces the query in `getServiceEntitySummary` with the v2\r\nfunction (`entityManagerClient.v2.searchEntities`)\r\n\r\n## Testing\r\n- Verify the response of the summary endpoint in the UI:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ba895f7d-57c8-492b-81dd-cf7869ffbc86\r\n\r\n\r\n\r\n- Dev tools query\r\n - APM service\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node-0/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response\r\n ```\r\n {\r\n \"serviceName\": \"synth-node-0\",\r\n \"agentName\": \"nodejs\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:29:19.868Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: simple_trace\"\r\n ]\r\n }\r\n ```\r\n\r\n - Service from logs\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response: \r\n ```\r\n {\r\n \"serviceName\": \"synth-node\",\r\n \"agentName\": \"go\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:27:43.461Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: logs_traces_hosts\"\r\n ]\r\n }\r\n ```\r\n\r\n---------\r\n\r\nCo-authored-by: Jenny <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a66c1399e60b184c338fc99c9550539bd2ecf68b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202497","number":202497,"mergeCommit":{"message":"[ECO][Inventory v2] APM changes (#202497)\n\nCloses [202299](https://github.com/elastic/kibana/issues/202299)\r\n\r\n## Summary\r\n\r\nThis PR replaces the query in `getServiceEntitySummary` with the v2\r\nfunction (`entityManagerClient.v2.searchEntities`)\r\n\r\n## Testing\r\n- Verify the response of the summary endpoint in the UI:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ba895f7d-57c8-492b-81dd-cf7869ffbc86\r\n\r\n\r\n\r\n- Dev tools query\r\n - APM service\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node-0/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response\r\n ```\r\n {\r\n \"serviceName\": \"synth-node-0\",\r\n \"agentName\": \"nodejs\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:29:19.868Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: simple_trace\"\r\n ]\r\n }\r\n ```\r\n\r\n - Service from logs\r\n #### Request:\r\n ```\r\nGET\r\nkbn:/internal/apm/entities/services/synth-node/summary?environment=ENVIRONMENT_ALL\r\n ```\r\n #### Response: \r\n ```\r\n {\r\n \"serviceName\": \"synth-node\",\r\n \"agentName\": \"go\",\r\n \"lastSeenTimestamp\": \"2024-12-13T16:27:43.461Z\",\r\n \"dataStreamTypes\": [\r\n \"logs\",\r\n \"traces\"\r\n ],\r\n \"environments\": [\r\n \"Synthtrace: logs_traces_hosts\"\r\n ]\r\n }\r\n ```\r\n\r\n---------\r\n\r\nCo-authored-by: Jenny <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a66c1399e60b184c338fc99c9550539bd2ecf68b"}}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Closes [202299](elastic#202299) ## Summary This PR replaces the query in `getServiceEntitySummary` with the v2 function (`entityManagerClient.v2.searchEntities`) ## Testing - Verify the response of the summary endpoint in the UI: https://github.com/user-attachments/assets/ba895f7d-57c8-492b-81dd-cf7869ffbc86 - Dev tools query - APM service #### Request: ``` GET kbn:/internal/apm/entities/services/synth-node-0/summary?environment=ENVIRONMENT_ALL ``` #### Response ``` { "serviceName": "synth-node-0", "agentName": "nodejs", "lastSeenTimestamp": "2024-12-13T16:29:19.868Z", "dataStreamTypes": [ "logs", "traces" ], "environments": [ "Synthtrace: simple_trace" ] } ``` - Service from logs #### Request: ``` GET kbn:/internal/apm/entities/services/synth-node/summary?environment=ENVIRONMENT_ALL ``` #### Response: ``` { "serviceName": "synth-node", "agentName": "go", "lastSeenTimestamp": "2024-12-13T16:27:43.461Z", "dataStreamTypes": [ "logs", "traces" ], "environments": [ "Synthtrace: logs_traces_hosts" ] } ``` --------- Co-authored-by: Jenny <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 202299
Summary
This PR replaces the query in
getServiceEntitySummarywith the v2 function (entityManagerClient.v2.searchEntities)Testing
apm_v2.mov
APM service
Request:
Response
Service from logs
Request:
Response: