-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-presentation
#202664
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-presentation
#202664
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/kbn-test/src/jest/setup/polyfills.jsdom.js
and src/dev/code_coverage/ingest_coverage/__tests__/mocks/team_assign_mock.txt
changes LGTM
@kibana/presentation
@kibana/presentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCSS files only
@kibana/presentation
@elastic/kibana-presentation
508e22d
to
34d4af1
Compare
edbfffa
to
3035be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code ql change LGTM!
7ebb820
to
7d38208
Compare
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbn/file-upload-plugin
has been relocated, LGTM
Closing this PR in favour of #204843 which only migrates some of the Presentation team's ownership. A follow up PR will move the rest of it at a quieter time. |
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]
andplugins[\/\\]
patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.ts
to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.ts
and.js
files listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
21 plugin(s) are going to be relocated:
@kbn/canvas-plugin
x-pack/platform/plugins/private/canvas
@kbn/controls-plugin
src/platform/plugins/shared/controls
@kbn/dashboard-enhanced-plugin
x-pack/platform/plugins/shared/dashboard_enhanced
@kbn/dashboard-plugin
src/platform/plugins/shared/dashboard
@kbn/embeddable-enhanced-plugin
x-pack/platform/plugins/shared/embeddable_enhanced
@kbn/embeddable-plugin
src/platform/plugins/shared/embeddable
@kbn/expression-error-plugin
src/platform/plugins/shared/expression_error
@kbn/expression-image-plugin
src/platform/plugins/shared/expression_image
@kbn/expression-metric-plugin
src/platform/plugins/shared/expression_metric
@kbn/expression-repeat-image-plugin
src/platform/plugins/shared/expression_repeat_image
@kbn/expression-reveal-image-plugin
src/platform/plugins/shared/expression_reveal_image
@kbn/expression-shape-plugin
src/platform/plugins/shared/expression_shape
@kbn/file-upload-plugin
x-pack/platform/plugins/private/file_upload
@kbn/input-control-vis-plugin
src/platform/plugins/private/input_control_vis
@kbn/inspector-plugin
src/platform/plugins/shared/inspector
@kbn/links-plugin
src/platform/plugins/private/links
@kbn/maps-ems-plugin
src/platform/plugins/private/maps_ems
@kbn/maps-plugin
x-pack/platform/plugins/shared/maps
@kbn/presentation-panel-plugin
src/platform/plugins/private/presentation_panel
@kbn/presentation-util-plugin
src/platform/plugins/shared/presentation_util
@kbn/vis-type-markdown-plugin
src/platform/plugins/private/vis_type_markdown
6 packages(s) are going to be relocated:
@kbn/flot-charts
src/platform/packages/shared/kbn-flot-charts
@kbn/mapbox-gl
src/platform/packages/private/kbn-mapbox-gl
@kbn/maps-vector-tile-utils
x-pack/platform/packages/private/maps/vector_tile_utils
@kbn/panel-loader
src/platform/packages/private/kbn-panel-loader
@kbn/presentation-containers
src/platform/packages/shared/presentation/presentation_containers
@kbn/presentation-publishing
src/platform/packages/shared/presentation/presentation_publishing
Updated references
Updated relative paths